From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65451: 30.0.50; `after-change-functions' are not triggered in the same order the changes are made Date: Sat, 30 Mar 2024 23:02:14 -0400 Message-ID: References: <871qfv2zlk.fsf@localhost> <83a5ujtgfo.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35036"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alan Mackenzie , Ihor Radchenko , 65451@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 31 05:03:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rqlTe-0008rd-5E for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Mar 2024 05:03:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqlTM-0006Xn-Ns; Sat, 30 Mar 2024 23:03:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqlTI-0006XX-LO for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 23:03:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rqlTI-00056F-8v for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 23:03:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rqlTK-0007sX-GK for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 23:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Mar 2024 03:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65451 X-GNU-PR-Package: emacs Original-Received: via spool by 65451-submit@debbugs.gnu.org id=B65451.171185414630208 (code B ref 65451); Sun, 31 Mar 2024 03:03:02 +0000 Original-Received: (at 65451) by debbugs.gnu.org; 31 Mar 2024 03:02:26 +0000 Original-Received: from localhost ([127.0.0.1]:46401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqlSj-0007rA-HH for submit@debbugs.gnu.org; Sat, 30 Mar 2024 23:02:25 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:1230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqlSi-0007qw-2o for 65451@debbugs.gnu.org; Sat, 30 Mar 2024 23:02:24 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 66DA180D32; Sat, 30 Mar 2024 23:02:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1711854135; bh=tIlogMunJ5PLkGfurLQcu8OO8JuvJ3zXmkOkK1WFgT0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=LkO14kspMsWefAku5qnmPaYUN1yRbJaM8dDCJufV+OWQXYDnL+0gKx5TGajhLBpJo HbnAxO04gMz1hCeQAUDiOocS3d1zGwPWACS3ZiVALPYAb0eIUNo6+ogaBhYoO6Apd0 JO91rH1K6oXrsHMnR7w+FCDhguNTtBh7xUk2Y2ada7Ku/+8ToNMInO6BnhuTfgnnKr T9s1Z8aGi37XsIoZm3E2NXs424ET4P5U0ee7Bc0DlUCLz6m5peLY1j9EMKEdPp4tlP APQr+hJa0khzkwMyqgFwG0861gtKVO9utpVOwYmcs3ykVkqE9VedX2r2DPlbpbDI5r hvje50CL+FwZw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6351780A6B; Sat, 30 Mar 2024 23:02:15 -0400 (EDT) Original-Received: from pastel (unknown [45.72.201.215]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3614312030A; Sat, 30 Mar 2024 23:02:15 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Sat, 30 Mar 2024 09:51:59 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282407 Archived-At: > I suspect the best option in the above case is to inhibit the inner > calls to before/after (assuming we're sure they change only the "new > text"), so we'd be down to: > > =E2=9B=94 Warning (emacs): Before: 1278 1281 > =E2=9B=94 Warning (emacs): After: 1278 1288 delta: 7 A simpler option is the patch below. Stefan diff --git a/src/search.c b/src/search.c index 2ad565fadde..83ff7120e43 100644 --- a/src/search.c +++ b/src/search.c @@ -2769,6 +2769,8 @@ DEFUN ("replace-match", Freplace_match, Sreplace_matc= h, 1, 5, 0, /* Replace the old text with the new in the cleanest possible way. */ replace_range (sub_start, sub_end, newtext, 1, 0, 1, true, true); =20 + signal_after_change (sub_start, sub_end - sub_start, SCHARS (newtext)); + if (case_action =3D=3D all_caps) Fupcase_region (make_fixnum (search_regs.start[sub]), make_fixnum (newpoint), @@ -2792,7 +2794,6 @@ DEFUN ("replace-match", Freplace_match, Sreplace_matc= h, 1, 5, 0, /* Now move point "officially" to the end of the inserted replacement. = */ move_if_not_intangible (newpoint); =20 - signal_after_change (sub_start, sub_end - sub_start, SCHARS (newtext)); update_compositions (sub_start, newpoint, CHECK_BORDER); =20 return Qnil;