From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer) Date: Sun, 05 May 2024 10:57:51 -0400 Message-ID: References: <86ttjr2pzw.fsf@gnu.org> <86edau3gyy.fsf@gnu.org> <8634ra36ny.fsf@gnu.org> <861q6ou2cs.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7853"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Richard Copley , 70541-done@debbugs.gnu.org, Eli Zaretskii To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 05 16:58:56 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3dKJ-0001mf-OW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 May 2024 16:58:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3dK4-0002DV-0O; Sun, 05 May 2024 10:58:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3dK2-0002DB-UB for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 10:58:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s3dK2-0004zP-MO for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 10:58:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s3dKQ-0000RO-1V for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 10:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 May 2024 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70541 X-GNU-PR-Package: emacs Original-Received: via spool by 70541-done@debbugs.gnu.org id=D70541.17149211161688 (code D ref 70541); Sun, 05 May 2024 14:59:02 +0000 Original-Received: (at 70541-done) by debbugs.gnu.org; 5 May 2024 14:58:36 +0000 Original-Received: from localhost ([127.0.0.1]:60161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3dJz-0000RA-MD for submit@debbugs.gnu.org; Sun, 05 May 2024 10:58:35 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3dJu-0000R0-T4 for 70541-done@debbugs.gnu.org; Sun, 05 May 2024 10:58:34 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 61D0A808A3; Sun, 5 May 2024 10:58:01 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1714921080; bh=0fJGHF+huerckNR7JsIcVs0au9DBZOsOkBvB8vZsbQw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=jlgoDf0wdIzSBB95HywULUOb7WVZoqNL1Wy4gTrJYRq9bRtroedm4InGTKzqWLPrN /yslB2iMEAA24sKxfRTuvLot37gSPc8Kqsfna7pvMLn0rLDt9fw4gh8Xl8NEGlGBNT Ci8X9XR3QR/1ziJ8SDXUcHSzDNTrq1MB3n/fKD0GSk1Xft8hCUGSGqIFVu9T/ZOTuw JG1fQFOY8dkxkPrp/OItpbcUxyq0kDKloXS/YXgAyZV7GvSgVq5/K8v5uTpvuF8LoQ ypPbX0TxDvBMHN5pjYFJSWaOwg7/z5ZqNBpnAztZQleXwN5eii4YDC+WzgmeH2K8zG hoedz4rXkxRmQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4E6BE805BE; Sun, 5 May 2024 10:58:00 -0400 (EDT) Original-Received: from pastel (unknown [45.72.201.215]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 20645120422; Sun, 5 May 2024 10:58:00 -0400 (EDT) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 5 May 2024 14:55:06 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284505 Archived-At: > Is this really the final word on this whole topic? The current > solution involves a one shot addition to `post-command-hook` in Eglot > and is really ugly. Can you really really no better solution so that > Eglot is only compelled to send changes to the server once > track-changes.el announces it safe to do so (and gives the change to > send while it's at it? Until we've gotten rid of all the code chunks that incorrectly use `inhibit-modification-hooks` (which will take a lot of time since not only we have to find them but we have to figure out why they used `inhibit-modification-hooks` and then argue hard to get the change to be accepted), I don't see a significantly simpler solution, no. =F0=9F=99=81 I mean, a simpler solution is to live with the performance bug, of course. > Also, tangentially , can we get rid of the fboundp's and make the next GNU > ELPA version run the same code as Emacs master's by depending on > track-changes.el GNU core? Yes, coming right up. > Also also, can you fix indentation in the function that you recently > touched in Eglot? (same goes for Philip, but I'll contact him > separately). Hmm... hadn't notice anything wrong. Will take a closer look, thanks for the heads up. Stefan