From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#2134: [PATCH] progmodes/compile.el: check global-font-lock-mode Date: Sun, 01 Feb 2009 17:54:47 -0500 Message-ID: References: <87tz7ffyc9.fsf@jondo.cante.net> <87zlh68mf5.fsf@jondo.cante.net> Reply-To: Stefan Monnier , 2134@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1233596165 30667 80.91.229.12 (2 Feb 2009 17:36:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Feb 2009 17:36:05 +0000 (UTC) Cc: 2134@emacsbugs.donarmstrong.com To: Jari Aalto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 02 18:37:19 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LU2j9-0004T9-L5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Feb 2009 18:36:57 +0100 Original-Received: from localhost ([127.0.0.1]:57909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LU2hr-0002G9-1h for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Feb 2009 12:35:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LU2WI-0006uw-43 for bug-gnu-emacs@gnu.org; Mon, 02 Feb 2009 12:23:38 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LU2WF-0006sx-P5 for bug-gnu-emacs@gnu.org; Mon, 02 Feb 2009 12:23:37 -0500 Original-Received: from [199.232.76.173] (port=43765 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LU2WE-0006sR-Qz for bug-gnu-emacs@gnu.org; Mon, 02 Feb 2009 12:23:34 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:54738) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LU2WE-0002t5-1v for bug-gnu-emacs@gnu.org; Mon, 02 Feb 2009 12:23:34 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n12HNV1u005685; Mon, 2 Feb 2009 09:23:32 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n12HF61K003670; Mon, 2 Feb 2009 09:15:06 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 02 Feb 2009 17:15:06 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2134 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2134-submit@emacsbugs.donarmstrong.com id=B2134.12335945392054 (code B ref 2134); Mon, 02 Feb 2009 17:15:06 +0000 Original-Received: (at 2134) by emacsbugs.donarmstrong.com; 2 Feb 2009 17:08:59 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n12H8qW3002048 for <2134@emacsbugs.donarmstrong.com>; Mon, 2 Feb 2009 09:08:53 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AswEAD+3hknO+IQk/2dsb2JhbACBbsozhBQGgmw X-IronPort-AV: E=Sophos;i="4.37,366,1231131600"; d="scan'208";a="33208361" Original-Received: from 206-248-132-36.dsl.teksavvy.com (HELO ceviche.home) ([206.248.132.36]) by ironport2-out.teksavvy.com with ESMTP; 02 Feb 2009 12:08:46 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 4F103B406D; Sun, 1 Feb 2009 17:54:47 -0500 (EST) In-Reply-To: <87zlh68mf5.fsf@jondo.cante.net> (Jari Aalto's message of "Sun, 01 Feb 2009 12:46:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 02 Feb 2009 12:23:36 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24838 Archived-At: >>> Here is patch to not to turn on font-lock unconditionally. Patch is >>> against Emacs version control tree check out 2009-01-31. >> >> If you read the rest of the compile.el code, you'll see that it uses >> font-lock to do its job, which is why it's turned on unconditionally. > The buffer handling could be improved to work without font lock. In some Yes, we indeed want that. Patches welcome. The way it could work (most likely) is by not hooking directly into font-lock but using after-change-functions instead (and then probably call font-lock-fontify-region (or somesuch function) from it), and only set the `font-lock-face' property rather than `face'. Another way to do that, would be to change font-lock-mode to allow "invisible" activation such that `font-lock-face' is not remapped to `face' and such that font-lock keywords end up adding entries to `font-lock-face' rather than to `face', so that the user can later on turn on font-lock-mode (in normal mode) at which point all the faces would be activated. That would be better. Stefan