From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#9943: 24.0.91; Abort in check_glyph_memory Date: Thu, 03 Nov 2011 20:35:04 -0400 Message-ID: References: <4EB25C0C.3060806@gmx.at> <834nylm3c3.fsf@gnu.org> <8339e4na27.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1320366953 10242 80.91.229.12 (4 Nov 2011 00:35:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 4 Nov 2011 00:35:53 +0000 (UTC) Cc: 9943@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 04 01:35:49 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RM7l6-0000SS-Lr for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Nov 2011 01:35:48 +0100 Original-Received: from localhost ([::1]:53984 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RM7l6-0005cT-6t for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Nov 2011 20:35:48 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:58376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RM7ks-0005c9-SI for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2011 20:35:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RM7kr-00083G-JL for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2011 20:35:34 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RM7kr-00082P-6o for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2011 20:35:33 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RM7nH-0008Gf-8r for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2011 20:38:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Nov 2011 00:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9943 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 9943-submit@debbugs.gnu.org id=B9943.132036706231750 (code B ref 9943); Fri, 04 Nov 2011 00:38:02 +0000 Original-Received: (at 9943) by debbugs.gnu.org; 4 Nov 2011 00:37:42 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RM7mu-0008G2-WB for submit@debbugs.gnu.org; Thu, 03 Nov 2011 20:37:42 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RM7ms-0008Fu-AO for 9943@debbugs.gnu.org; Thu, 03 Nov 2011 20:37:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EANMys05MCoYy/2dsb2JhbABDqgWBBoFyAQEEAVYjBQsLNBIUGA0kiBW1MokfBJ0IhEyERQ X-IronPort-AV: E=Sophos;i="4.69,453,1315195200"; d="scan'208";a="146179237" Original-Received: from 76-10-134-50.dsl.teksavvy.com (HELO pastel.home) ([76.10.134.50]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 03 Nov 2011 20:35:05 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 6D4F8592DE; Thu, 3 Nov 2011 20:35:05 -0400 (EDT) In-Reply-To: <8339e4na27.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 03 Nov 2011 23:57:36 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 03 Nov 2011 20:38:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:53495 Archived-At: > Thanks, I installed the same fix in xfns.c. All this code duplication is really a bore. We should really create a new file (say "dispfns.c") where we can consolidate common code from xfns, nsfns, and w32fns. A good start would be that whenever we have to make the same fix at all 3 places, we rearrange the code locally to call a new function in dispfns.c which would receive the common part where the fix can then be applied. Stefan