unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: 10049@debbugs.gnu.org
Cc: deng@randomsample.de
Subject: bug#10049: 24.0.91; Setting generated-autoload-file as local variable not working correctly
Date: Sat, 19 Nov 2011 21:18:08 -0500	[thread overview]
Message-ID: <jwv7h2v1r1i.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <871ut5b129.fsf@engster.org> (David Engster's message of "Fri, 18 Nov 2011 21:58:06 +0100")

>> I think it is fixed now.
> ...and confirmed (again!) ;-)

Could you check if the (additional) patch below works as well?


        Stefan


=== modified file 'lisp/emacs-lisp/autoload.el'
--- lisp/emacs-lisp/autoload.el	2011-11-17 21:34:16 +0000
+++ lisp/emacs-lisp/autoload.el	2011-11-20 02:17:11 +0000
@@ -512,15 +512,7 @@
 
           (when output-start
             (let ((secondary-autoloads-file-buf
-                   (if (local-variable-p 'generated-autoload-file)
-                       (current-buffer))))
-	      ;; Ignore a buffer-local setting if it points to the
-	      ;; global value.  Otherwise we end up writing a mix of md5s
-	      ;; and time-stamps to the global file.  (Bug#10049)
-	      (and secondary-autoloads-file-buf
-		   outfile
-		   (not otherbuf)
-		   (setq secondary-autoloads-file-buf nil))
+                   (if otherbuf (current-buffer))))
               (with-current-buffer (marker-buffer output-start)
                 (save-excursion
                   ;; Insert the section-header line which lists the file name






  reply	other threads:[~2011-11-20  2:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14 22:12 bug#10049: 24.0.91; Setting generated-autoload-file as local variable not working correctly David Engster
2011-11-17  7:39 ` Glenn Morris
2011-11-17  8:36   ` David Engster
2011-11-17  9:40   ` David Engster
2011-11-17 17:27     ` Glenn Morris
2011-11-17 21:34   ` Glenn Morris
2011-11-18 20:58     ` David Engster
2011-11-20  2:18       ` Stefan Monnier [this message]
2011-11-20 19:00         ` David Engster
2011-11-21 14:30           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7h2v1r1i.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=10049@debbugs.gnu.org \
    --cc=deng@randomsample.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).