unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo Liu <sdl.web@gmail.com>
Cc: 13999@debbugs.gnu.org, Carsten Bormann <cabo@tzi.org>
Subject: bug#13999: 24.3.50; rng-validate-while-idle -> (error "Selecting deleted buffer")
Date: Tue, 19 Mar 2013 23:29:39 -0400	[thread overview]
Message-ID: <jwv7gl24upo.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m1d2uusydl.fsf@gmail.com> (Leo Liu's message of "Wed, 20 Mar 2013 08:33:58 +0800")

>> Right, rng-validate-while-idle needs to check that its buffer is
>> still live.  Ideally it should also disable the corresponding timer if
>> the buffer died.
>> Could someone take care of it?
> Last time I checked the timer is supposed to be removed after buffer
> being killed.  So this fix is not ideal but it gives us a hint that a
> recipe might involve killing the buffer.

Yes, clearly a recipe would require killing the buffer in such a way
that the timer is not canceled.  While we may want to try and fix the
hole that lets this happen, I think it's still worthwhile to defensively
make rng-validate-while-idle check that the buffer is still live, since
the other problem may be anywhere in some unrelated code (potentially
external to Emacs) that let-binds kill-buffer-hook (for example).


        Stefan





  reply	other threads:[~2013-03-20  3:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 15:35 bug#13999: 24.3.50; rng-validate-while-idle -> (error "Selecting deleted buffer") Carsten Bormann
2013-03-19 15:55 ` Leo Liu
2013-03-19 20:51 ` Stefan Monnier
2013-03-20  0:33   ` Leo Liu
2013-03-20  3:29     ` Stefan Monnier [this message]
2013-03-20  4:30       ` Leo Liu
2013-03-22  9:55         ` Leo Liu
2013-03-22 13:36           ` Stefan Monnier
2013-03-22 14:39             ` Leo Liu
2013-03-22 17:34               ` Stefan Monnier
2013-03-23  1:47                 ` Leo Liu
2013-03-23  7:54                   ` Carsten Bormann
2013-03-23 14:13                     ` Leo Liu
2013-03-23  3:28       ` Leo Liu
2013-03-23 16:10         ` Stefan Monnier
2013-03-24  6:51           ` Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7gl24upo.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=13999@debbugs.gnu.org \
    --cc=cabo@tzi.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).