From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Xue Fuqiao <xfq.free@gmail.com>, Tassilo Horn <tsdh@gnu.org>
Cc: 15466@debbugs.gnu.org
Subject: bug#15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode
Date: Thu, 26 Sep 2013 14:05:09 -0400 [thread overview]
Message-ID: <jwv7ge3zcj6.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <CAAF+z6HEE2qtUV0STzvAm=rWJw=nx6UeBeXywXmXZQ==Qj=j9g@mail.gmail.com> (Xue Fuqiao's message of "Thu, 26 Sep 2013 22:14:54 +0800")
> (define-key map (kbd "RET") 'image-next-line)
> ;; Zoom in/out.
> (define-key map "+" 'doc-view-enlarge)
> + (define-key map "=" 'doc-view-enlarge)
> + (define-key map (kbd "C-x C-+") 'doc-view-enlarge)
> + (define-key map (kbd "C-x C-=") 'doc-view-enlarge)
> (define-key map "-" 'doc-view-shrink)
> + (define-key map (kbd "C-x C--") 'doc-view-shrink)
> ;; Fit the image to the window
> (define-key map "W" 'doc-view-fit-width-to-window)
> (define-key map "H" 'doc-view-fit-height-to-window)
I think it's OK (unless Tassilo disagrees, obviously), but it needs some
comments about why it's added (for the = binding, I guess it's because
it's the "unshifted +", which for the other it's to override
text-scale-adjust).
Also, maybe instead of rebinding C-x C-+, we should remap text-scale-adjust.
Stefan
next prev parent reply other threads:[~2013-09-26 18:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 14:14 bug#15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode Xue Fuqiao
2013-09-26 18:05 ` Stefan Monnier [this message]
2013-09-26 18:38 ` Tassilo Horn
2013-09-26 19:08 ` Tassilo Horn
2013-09-27 6:50 ` Tassilo Horn
2013-09-27 13:04 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7ge3zcj6.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=15466@debbugs.gnu.org \
--cc=tsdh@gnu.org \
--cc=xfq.free@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).