From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#15767: closed (Re: bug#15767: 24.3; [patch] electric-indent-mode bug) Date: Tue, 05 Nov 2013 10:44:59 -0500 Message-ID: References: <04CD2009-757D-471D-8338-325882009851@boostpro.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1383666331 28692 80.91.229.3 (5 Nov 2013 15:45:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Nov 2013 15:45:31 +0000 (UTC) Cc: 15767@debbugs.gnu.org To: Dave Abrahams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 05 16:45:34 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vdiok-0007qB-2k for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Nov 2013 16:45:22 +0100 Original-Received: from localhost ([::1]:56851 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdioj-0002P2-Og for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Nov 2013 10:45:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdioY-0002Mw-Q0 for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 10:45:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdioR-0004S2-Gf for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 10:45:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdioR-0004R5-DK for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 10:45:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VdioQ-0004Mm-Fm for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 10:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Nov 2013 15:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15767 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15767-submit@debbugs.gnu.org id=B15767.138366630116769 (code B ref 15767); Tue, 05 Nov 2013 15:45:02 +0000 Original-Received: (at 15767) by debbugs.gnu.org; 5 Nov 2013 15:45:01 +0000 Original-Received: from localhost ([127.0.0.1]:35928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdioO-0004MP-JT for submit@debbugs.gnu.org; Tue, 05 Nov 2013 10:45:00 -0500 Original-Received: from relais.videotron.ca ([24.201.245.36]:14220) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdioN-0004MH-9P for 15767@debbugs.gnu.org; Tue, 05 Nov 2013 10:44:59 -0500 Original-Received: from ceviche.home ([24.201.53.56]) by VL-VM-MR005.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MVS005S3RQY1200@VL-VM-MR005.ip.videotron.ca> for 15767@debbugs.gnu.org; Tue, 05 Nov 2013 10:44:58 -0500 (EST) Original-Received: by ceviche.home (Postfix, from userid 20848) id 9C7C76609C; Tue, 05 Nov 2013 10:44:59 -0500 (EST) In-reply-to: <04CD2009-757D-471D-8338-325882009851@boostpro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80021 Archived-At: > Well, the problem I see is that you left the call to line-beginning-posit= ion > where it was in the original call. At that point, point may be > on a different line than it started on, so it=E2=80=99s actually getting = information > about the wrong line. It=E2=80=99s possible that your patch somehow makes > everything work out, but leaving the call to line-beginning-position where > it is seems at best fragile to me. On the contrary, moving the call like you did was wrong, IMO. The test against line-beginning-position is meant to check if pos is on a previous line, in which case we also need to reindent that previous line, whereas with your patch it reduces to just check if pos is at (bolp) which is not as interesting (tho it will often work as well for the newline case). Stefan