unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Rasmus <rasmus@gmx.us>
Cc: 19335@debbugs.gnu.org
Subject: bug#19335: 24.4.51; ido.el: Include bookmark-files as virtual buffers
Date: Thu, 12 Mar 2015 10:13:27 -0400	[thread overview]
Message-ID: <jwv7fum486i.fsf-monnier+bug#19335@gnu.org> (raw)
In-Reply-To: <87oarbfyly.fsf@gmx.us> (rasmus@gmx.us's message of "Wed, 10 Dec 2014 14:00:57 +0100")

> -    (dolist (head recentf-list)
> +    (dolist (head (append recentf-list
> +                          (and (boundp 'bookmark-alist)
> +                               bookmark-alist
> +                               (mapcar
> +                                (lambda (bookmark)
> +                                  (cdr-safe (assoc 'filename bookmark)))
> +                                bookmark-alist))))

Looks OK, tho you should probably filter out nil elements in case
a bookmark entry doesn't have a `filename' (and OTOH I think `cdr-safe'
can be replaced by `cdr' because `assoc' can only return a cons or nil).


        Stefan





  parent reply	other threads:[~2015-03-12 14:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10 13:00 bug#19335: 24.4.51; ido.el: Include bookmark-files as virtual buffers Rasmus
2015-01-08 22:14 ` Rasmus
2015-03-11 15:49 ` bug#19335: Patch review Rasmus
2015-03-12 14:13 ` Stefan Monnier [this message]
2015-03-12 14:45   ` bug#19335: 24.4.51; ido.el: Include bookmark-files as virtual buffers Rasmus
2015-03-12 19:03     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='jwv7fum486i.fsf-monnier+bug#19335@gnu.org' \
    --to=monnier@iro.umontreal.ca \
    --cc=19335@debbugs.gnu.org \
    --cc=rasmus@gmx.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).