unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Mark Karpov <markkarpov@openmailbox.org>, 21329@debbugs.gnu.org
Subject: bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros
Date: Tue, 25 Aug 2015 09:15:58 -0400	[thread overview]
Message-ID: <jwv7foj345v.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <83io84hhte.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 24 Aug 2015 17:39:09 +0300")

> The problem is that 'sit-for' calls 'read-event', and then "undoes"
> that by pushing the events it read onto unread-command-events.

Indeed, that's a problem.  The right fix would be to change the code so
as not to consume any event in the first place.

> Or maybe we should introduce an "unrecord-key" facility for use by
> code such as we have in sit-for?

We could try, but I don't believe we can provide an "unrecord-key"
that's actually reliable.  AFAIK the act of taking an event out of the
queue has too many effects to have a hope of properly reverting
them all.


        Stefan





  reply	other threads:[~2015-08-25 13:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-23 11:57 bug#21329: 25.0.50; Flyspell minor mode produces weird effects on keyboard macros Mark Karpov
2015-08-24 14:39 ` Eli Zaretskii
2015-08-25 13:15   ` Stefan Monnier [this message]
2015-08-25 15:26     ` Eli Zaretskii
2015-08-25 16:31       ` Eli Zaretskii
2015-08-25 22:23         ` Stefan Monnier
2015-08-26  2:44           ` Eli Zaretskii
2015-08-28  1:33             ` Stefan Monnier
2015-08-28 13:28               ` Eli Zaretskii
2015-08-29 15:31                 ` Stefan Monnier
2015-08-29 16:22                   ` Eli Zaretskii
2015-08-30  2:06                     ` Stefan Monnier
2015-08-30  2:08                     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv7foj345v.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=21329@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=markkarpov@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).