From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: Philipp Stephani <phst@google.com>, 20852@debbugs.gnu.org
Subject: bug#20852: [PATCH] Warn about missing backslashes during load
Date: Mon, 01 May 2017 13:59:33 -0400 [thread overview]
Message-ID: <jwv7f20lb8v.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <20170501142718.3510-1-phst@google.com> (Philipp Stephani's message of "Mon, 1 May 2017 16:27:18 +0200")
Looks great, thank you very much. See comments below.
> + if (c == '(' || c == ')' || c == '[' || c == ']'
> + || c == '"' || c == ';')
These are indeed the most important ones w.r.t elisp-mode's
syntax-table, but I think we should put #, ?, and ' in there as well.
This said, maybe we should add chars in there "little by little" to try
and not overwhelm people with warnings.
So the above set might actually be a good set with which to start.
> + doc: /* List of deprecated unescaped character literals encountered by `read'. For internal use only. */);
Please keep the first line of docstrings with 80 columns. I.e. move the
"For internal use only." to a second line.
Stefan
next prev parent reply other threads:[~2017-05-01 17:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 19:22 bug#20852: 24.3; update-file-autoloads doesn't accept unescaped parenthesis character literal Philipp Stephani
2015-06-19 21:24 ` Stefan Monnier
2015-06-21 12:13 ` Philipp Stephani
2015-06-22 1:18 ` Stefan Monnier
2015-06-28 13:12 ` Philipp Stephani
2015-06-30 20:43 ` Philipp Stephani
2015-07-02 15:50 ` Stefan Monnier
[not found] ` <20170501142718.3510-1-phst@google.com>
2017-05-01 17:59 ` Stefan Monnier [this message]
2017-05-01 18:41 ` bug#20852: [PATCH] Warn about missing backslashes during load Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7f20lb8v.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=20852@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).