From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#9923: 24.0.91; `where-is' does not find recentf menu items (cmds, not files) Date: Thu, 30 Sep 2021 08:43:21 -0400 Message-ID: References: <76FA3F83D086455EAA01FF0FB000FCDB@us.oracle.com> <871r6hk99k.fsf@gnus.org> <87bl5k2ug1.fsf@gnus.org> <87czpwb4gw.fsf@mail.linkov.net> <87y28kf5sn.fsf@gnus.org> <87r1ebz98c.fsf@mail.linkov.net> <875yvm8oqk.fsf@gnus.org> <87v93mazvm.fsf@mail.linkov.net> <875yvmj9ir.fsf@gnus.org> <87pmsqeena.fsf@mail.linkov.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27843"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 9923@debbugs.gnu.org, Lars Ingebrigtsen , Drew Adams To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 30 14:44:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVvQ7-000717-73 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Sep 2021 14:44:15 +0200 Original-Received: from localhost ([::1]:36110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVvQ6-0004F4-6W for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Sep 2021 08:44:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVvPu-0004A4-Di for bug-gnu-emacs@gnu.org; Thu, 30 Sep 2021 08:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40169) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVvPu-0005vH-5A for bug-gnu-emacs@gnu.org; Thu, 30 Sep 2021 08:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVvPu-0006YD-3C for bug-gnu-emacs@gnu.org; Thu, 30 Sep 2021 08:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Sep 2021 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9923 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 9923-submit@debbugs.gnu.org id=B9923.163300581225138 (code B ref 9923); Thu, 30 Sep 2021 12:44:02 +0000 Original-Received: (at 9923) by debbugs.gnu.org; 30 Sep 2021 12:43:32 +0000 Original-Received: from localhost ([127.0.0.1]:51715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVvPP-0006XO-MO for submit@debbugs.gnu.org; Thu, 30 Sep 2021 08:43:31 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVvPN-0006XA-SL for 9923@debbugs.gnu.org; Thu, 30 Sep 2021 08:43:30 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E9A188075E; Thu, 30 Sep 2021 08:43:23 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 751E980084; Thu, 30 Sep 2021 08:43:22 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1633005802; bh=HphKN+CM3lUqcN62anUvGa93fDfnMnIvGKN6nU39H8Y=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fKdYSeQFiadmYPTz7XmPqjZkEN/EtYWB5oONZNqY5D93MOTlUJS5pVOCowENrKWs+ dECFt5lwZiSb7fyP6Q1kljEM5X4rXPJl8x+/yh5ITNAt5eUouzv//OmE6TrOy16Z7T iIR1H44r64pZzzcDomtrp1sVqQ8d8G2I/LHWDSGxnw3+jk01nqG94w/wJQfAvlRcR5 A3pYw8xkh7gwdR5fNgZhLAnUtcyUmpfFoWqO1CoDqs+/8NWMxFNu1O4fZP/A1S/IXp BQXTqv433+a+q9MhM5VTy9KRslIlc7RWZ0fsEtt/zCnkIMgfM47F/sFARzIzieUqSJ sGY3c5CO6S8JA== Original-Received: from milanesa (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1EABD1201BE; Thu, 30 Sep 2021 08:43:22 -0400 (EDT) In-Reply-To: <87pmsqeena.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 30 Sep 2021 09:55:21 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215967 Archived-At: > Recently clicking the context menu at the end of the buffer raises an error, > and during the short time period before the problem was noticed and fixed, > the error in one context menu item broke completion of M-x. > It might surprise the users why an error in context menus > affects such unrelated things. So maybe such patch makes sense > to prevent M-x completion from breaking? > > diff --git a/lisp/simple.el b/lisp/simple.el > index b0ff4236e1..5581d41356 100644 > --- a/lisp/simple.el > +++ b/lisp/simple.el > @@ -2117,7 +2117,9 @@ read-extended-command--affixation > (mapcar > (lambda (command-name) > (let* ((fun (and (stringp command-name) (intern-soft command-name))) > - (binding (where-is-internal fun overriding-local-map t)) > + (binding (unless (eq fun 'ignore) > + ;; Ignore errors in context-menu. > + (where-is-internal fun overriding-local-map t))) I think adding code specific to context-menu in `read-extended-command--affixation` is a bad idea. So maybe we should add an `with-demoted-errors` and just mention context-menu as an example of the kind of errors we want to disregard. Or maybe we should investigate why `ignore` causes an error here? Stefan