From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#45764: icomplete in buffer completion does not work for completion-at-point Date: Tue, 07 Jun 2022 10:43:08 -0400 Message-ID: References: <140804236.117906.1610282126510@office.mailbox.org> <87y1y8hagm.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30330"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: simon254@mailbox.org, 45764@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 07 16:44:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyaRN-0007Zz-7a for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Jun 2022 16:44:17 +0200 Original-Received: from localhost ([::1]:46758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyaRL-0005wN-PI for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Jun 2022 10:44:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyaR7-0005vW-UA for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 10:44:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47225) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nyaR7-00065f-Lt for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 10:44:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nyaR7-0007wp-KX for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 10:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jun 2022 14:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 45764-submit@debbugs.gnu.org id=B45764.165461299930498 (code B ref 45764); Tue, 07 Jun 2022 14:44:01 +0000 Original-Received: (at 45764) by debbugs.gnu.org; 7 Jun 2022 14:43:19 +0000 Original-Received: from localhost ([127.0.0.1]:41122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyaQR-0007vq-HK for submit@debbugs.gnu.org; Tue, 07 Jun 2022 10:43:19 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyaQQ-0007vd-Cp for 45764@debbugs.gnu.org; Tue, 07 Jun 2022 10:43:18 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A65D04426E1; Tue, 7 Jun 2022 10:43:12 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 617854426DF; Tue, 7 Jun 2022 10:43:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1654612991; bh=kDN+Mz4tUCqoAnSOBqaZ0kpM5KvjjXZeLnFUWMdwV0E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Agegzr4ZYL5R9yM0aae95adk+Cr116UVQwoOM6O2YfR38znTmimJbGuVd+w2UUGWi qsbZ8O+uuz3Auf2lc8vWYqCcwy1PPwYSMKJnNGSjGMvER6/7bwKFyYs9z1DglruTVg O0EbaILeQG3NeKWJmHOzZRsMFIqWcOH/Bmy2Lb0TipClNb1GavyMqBXqUZ0vi29UFA Ea2MSIcGO6eJPmCYFCKVyE87rGpKvz6KR0CsPXdmLkJiHXOeK9qtbCjf9XEZltYoXb SRqPJtRs5P/qirkKGTT4KrNjJD+TiqVfj+x4tpxQeEtsdj50J3Tx7X4qXQqKKYg3pP 9dxKW8x4lNfrQ== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 230F2120193; Tue, 7 Jun 2022 10:43:11 -0400 (EDT) In-Reply-To: <87y1y8hagm.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 07 Jun 2022 15:25:29 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233900 Archived-At: > `C-j' is bound to `icomplete-force-complete-and-exit', and it calls > `minibuffer-force-complete-and-exit' unconditionally, which deletes the > buffer contents. There are 2 problems, both of which stem from the fact that the code has not been adjusted to the case where it's working in a normal buffer rather than in the minibuffer: - it calls `minibuffer-exit` which is wrong for in-buffer completion (it should probably exit `completion-in-region-mode` instead). - it assumes the area of completion is the whole buffer (it should probably use `icomplete--field-end/beg`). > I can't get icomplete-in-buffer to work in either *shell* or in other > modes -- has this feature gotten much testing/use? `icomplete-in-buffer` needs more love, indeed. [ BTW, I see its docstring says that it doesn't affect `dabbrev-completion` but that's not true any more. ] Stefan