From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
laszlomail@protonmail.com, Eli Zaretskii <eliz@gnu.org>,
45333@debbugs.gnu.org
Subject: bug#45333: complex command history should not save optional nil parameters
Date: Wed, 06 Jul 2022 14:41:19 -0400 [thread overview]
Message-ID: <jwv7d4qgkdv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87o7y3l1xm.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 05 Jul 2022 22:49:57 +0200")
>> (Which reminds me -- I've always found it odd that that function lives
>> in help.el, and is in Emacs Lisp instead of C. It is, after all, used
>> by eldoc etc, and it'd probably be nice if it were more efficient.)
> So I started taking a stab at this to see whether there's any gains to
> be had, and I've now basically rewritten it in C.
IIUC you're talking about `help-function-arglist`?
> And, yes, I think it makes sense, because we can avoid at least some
> garbage generating functions without contorting ourselves too much.
I can't think of any reason we'd ever want to use that function anywhere
near performance critical code, so I'd rather keep it in ELisp if
possible. `help.el` may not be the best choice for it, admittely.
Over the course of my hacking on OClosures, I had moved that code (and
the accompanying fundoc extraction/addition) to `subr.el` where I think
it might make more sense (together with a bit of renaming to take it out
of the `help-` namespace).
> One thing, though -- I'm not sure how to do the oclosure stuff from C,
> so I've added Stefan to the CCs. It's this bit:
>
> ;; Advice wrappers have "catch all" args, so fetch the actual underlying
> ;; function to find the real arguments.
> (setq def (advice--cd*r def))
OClosure or not doesn't make much of a difference here, I think (the
previous version of the code would also be quite hideous in C).
Why not just call `advice--cd*r`?
Stefan
next prev parent reply other threads:[~2022-07-06 18:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 9:01 bug#45333: complex command history should not save optional nil parameters novim via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-07 11:57 ` Lars Ingebrigtsen
2022-06-07 13:15 ` Eli Zaretskii
2022-06-07 13:20 ` Eli Zaretskii
2022-06-08 11:43 ` Lars Ingebrigtsen
2022-06-08 13:57 ` Eli Zaretskii
2022-06-09 10:22 ` Lars Ingebrigtsen
2022-06-09 10:33 ` Eli Zaretskii
2022-06-10 8:52 ` Lars Ingebrigtsen
2022-07-05 14:16 ` Michael Heerdegen
2022-07-05 14:53 ` Drew Adams
2022-07-05 16:41 ` Lars Ingebrigtsen
2022-07-05 18:45 ` Michael Heerdegen
2022-07-05 18:48 ` Lars Ingebrigtsen
2022-07-05 19:06 ` Michael Heerdegen
2022-07-05 19:09 ` Lars Ingebrigtsen
2022-07-05 19:43 ` Michael Heerdegen
2022-07-05 19:50 ` Lars Ingebrigtsen
2022-07-05 20:00 ` Drew Adams
2022-07-05 20:49 ` Lars Ingebrigtsen
2022-07-05 22:37 ` Drew Adams
2022-07-06 18:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-07-07 7:29 ` Lars Ingebrigtsen
2022-07-07 9:45 ` Lars Ingebrigtsen
2022-07-07 10:00 ` Stefan Kangas
2022-07-07 10:06 ` Lars Ingebrigtsen
2022-07-07 13:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-07 14:10 ` Lars Ingebrigtsen
2022-07-07 14:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-07 14:52 ` Lars Ingebrigtsen
2022-07-07 15:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-07 15:21 ` Lars Ingebrigtsen
2022-07-07 15:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-07 18:00 ` Lars Ingebrigtsen
2022-07-07 13:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-05 20:15 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7d4qgkdv.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=45333@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=laszlomail@protonmail.com \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).