From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50034: 28.0.50; elisp capf error "Wrong type argument: listp, elisp--witness--lisp" Date: Tue, 23 Aug 2022 10:17:52 -0400 Message-ID: References: <02b75b43-616e-51f1-5d7b-ecb2661d1838@daniel-mendler.de> <87v949ee54.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23761"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Daniel Mendler , 50034-done@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 23 16:19:58 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQUl4-0005yB-1n for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Aug 2022 16:19:58 +0200 Original-Received: from localhost ([::1]:50286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQUl2-00020o-Rk for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Aug 2022 10:19:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQUka-0001vX-R6 for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2022 10:19:28 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQUkA-0006h8-Mz for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2022 10:19:15 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oQUkA-0006Z4-94 for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2022 10:19:02 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Aug 2022 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 50034 X-GNU-PR-Package: emacs Mail-Followup-To: 50034@debbugs.gnu.org, monnier@iro.umontreal.ca, mail@daniel-mendler.de Original-Received: via spool by 50034-done@debbugs.gnu.org id=D50034.166126428325153 (code D ref 50034); Tue, 23 Aug 2022 14:19:02 +0000 Original-Received: (at 50034-done) by debbugs.gnu.org; 23 Aug 2022 14:18:03 +0000 Original-Received: from localhost ([127.0.0.1]:44706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQUjD-0006Xc-5f for submit@debbugs.gnu.org; Tue, 23 Aug 2022 10:18:03 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQUjB-0006X7-6C for 50034-done@debbugs.gnu.org; Tue, 23 Aug 2022 10:18:01 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 75E2B4416BB; Tue, 23 Aug 2022 10:17:55 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 135BD4416C7; Tue, 23 Aug 2022 10:17:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1661264274; bh=ZYEMG3t/vo0/dROf+OlGfCA3nL1ZJ/dddGmwpJA4nyc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iCWNAc4lldQifHlQCD/9jNFHVvdmU4athqVWOWsRlRr7e1r8Edj7e3zHynx0j1X6Q upyL10PQr5tc1KYyGpWUmZW7tam1IPI3D3Q9SKcqqDwZXNYed2u7mpSZ4Y1b5LL3En V53AiDMdW01HtWupbebXSJmknDoWjsbNLqD3DTIrmBsDAEcffW9245vjMrgvA401Mq cuhERrzUjl3PR6fsjszKKkLoFuy5rS34cZTzTxxT7CzvyHFpAyeKAeumaZ9JGrmpQv wzUqSMwfBtiQ/+Vi1d+zzRYDdZJ/yvbU8kPFVG+XAU1KdTr+6JsA44ypByMrj2jvdM dmXsIuaBoGq/A== Original-Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 950931203D5; Tue, 23 Aug 2022 10:17:53 -0400 (EDT) In-Reply-To: <87v949ee54.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 13 Aug 2021 14:13:27 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240544 Archived-At: > Slightly simpler repro: > > (defmacro foo bar > M-: (elisp--local-variables) RET > > It fails here: > > (`(lambda ,args . ,body) > (elisp--local-variables-1 > (append (remq '&optional (remq '&rest args)) vars) > (car (last body)))) > > where it expects args to be a list, but it's the symbol > `elisp--witness--lisp'. Since the code can be completely non-sensical, `elisp--local-variables` shouldn't presume that the arglist is indeed a list. I installed the fix below on `master`. Stefan diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el index 0c4a9bfdbea..6d8ced7f220 100644 --- a/lisp/progmodes/elisp-mode.el +++ b/lisp/progmodes/elisp-mode.el @@ -383,7 +383,9 @@ elisp--local-variables-1 (setq sexp nil)) (`(lambda ,args . ,body) (elisp--local-variables-1 - (append (remq '&optional (remq '&rest args)) vars) + (let ((args (if (listp args) args))) + ;; FIXME: Exit the loop if witness is in args. + (append (remq '&optional (remq '&rest args)) vars)) (car (last body)))) (`(condition-case ,_ ,e) (elisp--local-variables-1 vars e)) (`(condition-case ,v ,_ . ,catches)