From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Date: Mon, 30 Jan 2023 09:54:09 -0500 Message-ID: References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38835"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60845@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 30 15:55:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMVYv-0009uQ-UO for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Jan 2023 15:55:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMVYm-0000GI-Dp; Mon, 30 Jan 2023 09:55:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMVYk-0000Ff-O6 for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 09:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMVYk-0000eD-FV for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 09:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMVYk-0005Xe-CX for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 09:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2023 14:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60845-submit@debbugs.gnu.org id=B60845.167509046121246 (code B ref 60845); Mon, 30 Jan 2023 14:55:02 +0000 Original-Received: (at 60845) by debbugs.gnu.org; 30 Jan 2023 14:54:21 +0000 Original-Received: from localhost ([127.0.0.1]:46853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMVY4-0005Wc-U0 for submit@debbugs.gnu.org; Mon, 30 Jan 2023 09:54:21 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:50623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMVY3-0005WQ-Gw for 60845@debbugs.gnu.org; Mon, 30 Jan 2023 09:54:20 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7111F808F0; Mon, 30 Jan 2023 09:54:13 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A42A0803B4; Mon, 30 Jan 2023 09:54:11 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1675090451; bh=fMakV2cggqyapjPthiFiYC9ja1+plSnogK0JRBNZBrg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XaR+jQpQeBOigc5jDikKWnZCG7b91tF6xUz9FE/+Yvlw4FOKlYZq0TmWAxIJPzfky fTqJUrYNHtgec//hCnf2QTA4rFcsjkbOqXaRJmL9O2inLB+lXko+/zgkOvTME2mDQE MoJRhf6mgkS5vZXLIDNfZMFJXFJnK8M6/9K5LQiYXXclckud9owIvtFd9jkpzsXQNX DhH3HDaq+UQi9U9BEjv8I55czoThDQowxNqjw6ifNnFdvfM+awUrgZKXtlgDHzdEZL lxHnjMRZusPKz3g5yHYN966RSpcPe91C3JO4zz4JaVwfrK4s2SwOMQUKuvU+/TMeyS hMb5O/y9N0ADA== Original-Received: from pastel (69-165-135-136.dsl.teksavvy.com [69.165.135.136]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2C609122501; Mon, 30 Jan 2023 09:54:11 -0500 (EST) In-Reply-To: <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> (Jim Porter's message of "Sun, 29 Jan 2023 23:14:49 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254438 Archived-At: >>> The third patch in this series fixes this for the Eshell side, so we >>> could probably remove the workaround in pcomplete.el for Emacs 30. > > Stefan, do you have any thoughts on these changes, especially the third > patch? I did a bit of tinkering with pcomplete functions, and I think it > should be ok for the Eshell side of things. Eshell-specific pcomplete > functions can get the real value if they need by examining the > 'pcomplete-arg-value' string property. > > For pcomplete functions that aren't Eshell-specific, they'll always get the > string form of arguments by default, so things should Just Work there. It sounds good to me, but I'm definitely not well versed in this aspect of the interaction between Eshell and Pcomplete (more specifically, this is a part of their interaction which I find quite tricky), so it's good that you add corresponding regression tests. Stefan