From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62732: 29.0.60; uniquify-trailing-separator-p affects any buffer whose name matches a dir in CWD Date: Mon, 10 Jul 2023 22:55:23 -0400 Message-ID: References: <87h6tpn8d5.fsf@catern.com> <87edotn7sx.fsf@catern.com> <87edlhm6wq.fsf@catern.com> <87o7kklf9c.fsf@catern.com> <83r0pf9b7d.fsf@gnu.org> <83fs5v8tsw.fsf@gnu.org> <83edlf89qp.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11996"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: sbaugh@catern.com, 62732@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 11 04:56:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJ3YD-0002v0-Tt for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Jul 2023 04:56:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJ3Xn-0002tq-MC; Mon, 10 Jul 2023 22:56:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJ3Xm-0002tc-ES for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 22:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJ3Xm-0005JH-7C for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 22:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJ3Xl-0003ln-Rc for bug-gnu-emacs@gnu.org; Mon, 10 Jul 2023 22:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jul 2023 02:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62732 X-GNU-PR-Package: emacs Original-Received: via spool by 62732-submit@debbugs.gnu.org id=B62732.168904414014465 (code B ref 62732); Tue, 11 Jul 2023 02:56:01 +0000 Original-Received: (at 62732) by debbugs.gnu.org; 11 Jul 2023 02:55:40 +0000 Original-Received: from localhost ([127.0.0.1]:49458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJ3XQ-0003lE-Ce for submit@debbugs.gnu.org; Mon, 10 Jul 2023 22:55:40 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJ3XO-0003l1-Du for 62732@debbugs.gnu.org; Mon, 10 Jul 2023 22:55:38 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DF71444184B; Mon, 10 Jul 2023 22:55:32 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9C94B441844; Mon, 10 Jul 2023 22:55:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689044131; bh=pk49SFa2KajRy4H54NaD5iG6NKj01VCjciYGyEYHijw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VLOQQVpY/Z8NoJ2f1tx3ftg6URAQopiVjZGuKnu3hSRJNT+3LX4UbnWSnk1FW7iZ7 WHc0EAjpuquV4+wH2fDJxadSTdv10r+sNEEusGuqabaUBmCZhyRo7oB0d0rt03r9oM oSy1fKUtpZgCPn5Pj+8Lx0D/ye/JaFurhrdaj5G/TU7vyqEX4tOzGdGER2GhMtXA+d WkGek/6qQHW9p0zo3DczIyuf46wvgq8yoPp11sbMLWadXnA8UJ0PuIOO4syy4bx2Rr 73tHKTm7iNTYhIRL6k8U0d976ImP60aV88M1F28oWc7mnFuy1zYXyxLcA1ynJ6M9Xo qIo7qH3Gj22wQ== Original-Received: from pastel (69-165-150-192.dsl.teksavvy.com [69.165.150.192]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6B4D812026C; Mon, 10 Jul 2023 22:55:31 -0400 (EDT) In-Reply-To: <83edlf89qp.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Jul 2023 05:25:50 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264916 Archived-At: >> No, `create-file-buffer` used to throw away the trailing slash, rather >> than make use of this information. [ And instead uniquify had to try and recover that information by checking the file-system. ] >> Not sure why Dired bothered to remove the tailing slash when calling >> it, maybe because a long time ago `create-file-buffer` had a bug if >> the name had a trailing slash. > So why the need for the change in dired.el? Because we do want Dired to tell `create-file-buffer` that this is a directory and it should thus obey `uniquify-trailing-separator-p`. Otherwise `uniquify-trailing-separator-p` would end up never used (since Dired is AFAIK the only package that creates "directory file buffers"). Stefan