From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sat, 15 Jul 2023 14:15:41 -0400 Message-ID: References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <83r0p9b3om.fsf@gnu.org> <83jzv1b152.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16284"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: yantar92@posteo.net, 64596@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 15 20:16:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKjom-00040y-5d for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jul 2023 20:16:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKjoO-0006SB-QK; Sat, 15 Jul 2023 14:16:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKjoN-0006Rw-98 for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 14:16:07 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKjoI-0006Ep-Hg for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 14:16:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKjoI-00080I-DF for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 14:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168944495930752 (code B ref 64596); Sat, 15 Jul 2023 18:16:02 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 15 Jul 2023 18:15:59 +0000 Original-Received: from localhost ([127.0.0.1]:46064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKjoF-0007zw-3J for submit@debbugs.gnu.org; Sat, 15 Jul 2023 14:15:59 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKjoA-0007zT-3A for 64596@debbugs.gnu.org; Sat, 15 Jul 2023 14:15:57 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D24B080327; Sat, 15 Jul 2023 14:15:48 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8E184801B3; Sat, 15 Jul 2023 14:15:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689444943; bh=RJQgviS1hhSkoO+ZHAR+r2kh59nvxAfnSpNhXhbY0eM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Z8Onog/JC8CYobmqGR/mEjt9qUUbobpW5/pzUqoDsAFOZFVN4opYDIIJRZmAMOT9P LdH5cs7oTH2H3Tswt/DQyqfxZRX2XGaWmeHtwS3IpgwwQp2RtlvWmDtqtn9+ANr3cO Y6GMepH49jIu/fqVNQFETDUWscMFHIZdMIdrOphnc66WFSji2m5pUgSqL73zAkmiaf CCojDQKUQ76XOp1qrTT9a2gj6xceVpb297TAh2OpahO0M04h0/ZhBgWRawiTYpteQJ F4H+/oAOMiWoA6vLlf7yklWe5sqSJamKI81r/Z+Q7ynfD7MhQyFygwobzexcVQlODy NHJUjuBGc1h9w== Original-Received: from pastel (unknown [108.175.230.17]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 10B791202F2; Sat, 15 Jul 2023 14:15:42 -0400 (EDT) In-Reply-To: <83jzv1b152.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Jul 2023 19:16:57 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265233 Archived-At: > Or why redisplay_internal does this: > > consider_all_windows_p = (update_mode_lines > || windows_or_buffers_changed); Sorry, I skipped this part in my previous email. I understand the above code, but I'm not sure what explanation might be needed so you can understand it as well. Maybe the problem is the name `consider_all_windows_p` which suggests that all windows will be updated, but it only says that we should loop through all the windows to try and find those which need to be updated. Would the patch below help? Stefan diff --git a/src/xdisp.c b/src/xdisp.c index a3464c2c375..385569d9309 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -16491,7 +16491,9 @@ redisplay_internal (void) int garbaged_frame_retries = 0; /* True means redisplay has to consider all windows on all - frames. False, only selected_window is considered. */ + frames. False, only selected_window is considered. + If true, the set of windows we try to update is further limited + according to the `redisplay` bits in buffers/windows/frames. */ bool consider_all_windows_p; /* True means redisplay has to redisplay the miniwindow. */