From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: Dmitry Gutov <dmitry@gutov.dev>, Eli Zaretskii <eliz@gnu.org>,
66732@debbugs.gnu.org, dominik@honnef.co
Subject: bug#66732: tree-sitter fontification doesn't update multi-line syntax reliably
Date: Wed, 13 Dec 2023 09:30:22 -0500 [thread overview]
Message-ID: <jwv7clichq6.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <FE4965D0-8308-4CB5-A8D6-E86118D0B955@gmail.com> (Yuan Fu's message of "Tue, 12 Dec 2023 23:12:31 -0800")
> The problem is, when you type /* RET foo RET */ the block comment is not fontified in comment face
>
> x
>
>
>
> That’s because before the user types the final “/“, there isn’t a complete
> comment node in the parse tree. When the user types the “/“, we need to mark
> the whole block comment for refontification.
>
> We actually have that, when the parser reparses, it’ll also compute the
> affected region, the region that changed during the last reparse, and it’ll
> call the “notifiers” with that region. We install a font-lock-notifier,
> which simply sets fontified text property to nil in that region, so
> redisplay would call jit-lock to fontify that region.
>
> In our example, the region would be the block comment.
Thanks.
If the reparse is done during `jit-lock` then, depending on how we do
it, it may indeed require re-running jit-lock, tho not necessarily.
E.g. if the reparse+notification is used to extend-region, then
fontification will already have been done and doesn't need to
be repeated.
OTOH the rendering will have already been done with the pre-reparse
state of the buffer for the beginning of the buffer (i.e. before the
"*/"), so we need to re-render (i.e. re-run the redisplay) for that part
of the buffer. But that should not need any re-parse nor re-fontification.
If your `font-lock-extend-region-function` returns correct bounds,
jit-lock should take care of re-rendering as needed.
If the reparse (and the corresponding setting of `fontified`) is done
before redisplay, then there should be no need to do any double work at
all. So maybe reparsing from a `pre-redisplay-functions` is an even
better option. The downside is that it doesn't save you from needing to
handle reparses from the `font-lock-extend-region-function`, in order to
handle the cases where the redisplay wasn't involved.
Stefan
next prev parent reply other threads:[~2023-12-13 14:30 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 14:22 bug#66732: tree-sitter fontification doesn't update multi-line syntax reliably Dominik Honnef
2023-10-24 23:15 ` Dmitry Gutov
2023-10-29 12:22 ` Eli Zaretskii
2023-11-18 8:37 ` Eli Zaretskii
2023-12-11 4:16 ` Yuan Fu
2023-12-11 12:05 ` Eli Zaretskii
2023-12-11 14:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-11 15:53 ` Dmitry Gutov
2023-12-12 7:50 ` Yuan Fu
2023-12-12 12:43 ` Dmitry Gutov
2023-12-13 3:28 ` Yuan Fu
2023-12-13 3:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 7:12 ` Yuan Fu
2023-12-13 14:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-12-14 1:43 ` Dmitry Gutov
2023-12-14 8:29 ` Yuan Fu
2023-12-15 1:01 ` Dmitry Gutov
2023-12-15 7:12 ` Yuan Fu
2023-12-16 5:56 ` Yuan Fu
2023-12-16 15:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 17:11 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 17:23 ` Dmitry Gutov
2023-12-16 17:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 19:18 ` Yuan Fu
2023-12-16 19:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 23:09 ` Dmitry Gutov
2023-12-17 1:16 ` Yuan Fu
2023-12-17 18:32 ` Dmitry Gutov
2023-12-19 3:12 ` Yuan Fu
2023-12-20 1:52 ` Dmitry Gutov
2023-12-20 5:43 ` Yuan Fu
2023-12-20 11:31 ` Dmitry Gutov
2023-12-16 23:02 ` Dmitry Gutov
2023-12-20 2:01 ` Dmitry Gutov
2023-12-20 3:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 22:56 ` Dmitry Gutov
2023-12-18 18:27 ` Dmitry Gutov
2023-12-18 19:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-18 19:33 ` Eli Zaretskii
2023-12-18 23:10 ` Dmitry Gutov
2023-12-19 3:22 ` Eli Zaretskii
2023-12-19 3:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 12:41 ` Eli Zaretskii
2023-12-19 12:44 ` Dmitry Gutov
2023-12-20 20:50 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-23 10:17 ` Eli Zaretskii
2023-12-23 18:02 ` Yuan Fu
2023-12-23 20:46 ` Dmitry Gutov
2023-12-23 20:51 ` Dmitry Gutov
2023-12-23 23:07 ` Yuan Fu
2023-12-24 2:10 ` Dmitry Gutov
2023-12-24 3:02 ` Yuan Fu
2023-12-23 20:55 ` Dmitry Gutov
2023-12-24 6:03 ` Eli Zaretskii
2024-02-08 1:40 ` Yuan Fu
2023-12-18 23:08 ` Dmitry Gutov
2023-12-20 20:50 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-12 15:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7clichq6.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=66732@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dmitry@gutov.dev \
--cc=dominik@honnef.co \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).