From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 75065@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
Konstantin Kharlamov <Hi-Angel@yandex.ru>
Subject: bug#75065: Upon archive download failure print the original error
Date: Thu, 26 Dec 2024 14:17:46 -0500 [thread overview]
Message-ID: <jwv7c7mtg2x.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87bjwytis3.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 26 Dec 2024 18:13:00 +0000")
>>> (dolist (archive package-archives)
>>> - (condition-case-unless-debug nil
>>> + (condition-case-unless-debug err
>>> (package--download-one-archive archive "archive-contents" async)
>>> - (error (message "Failed to download `%s' archive."
>>> - (car archive))))))
>>> + (error (message "Failed to download `%s' archive. Error: %S"
>>> + (car archive) (cdr err))))))
>>>
>> Stefan and Philip, is this okay to install?
I agree with the idea behind the patch, but printing just `(cdr err)`
doesn't seem right, it should print the whole of `err`.
> It seems harmless, I am just uncertain if we should prefer %S or %s to
> format the error message.
`%s` to print `err` or `(cdr err)` would be wrong, since `%s` is for use
with strings rather than lists. IOW, IMO, it should be either
...%S" ... err)
or
...%s" ... (error-message-string err))
where the first is a bit more "debugging/developer" friendly and the second
is a bit more "user" friendly.
Stefan
next prev parent reply other threads:[~2024-12-26 19:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-24 15:25 bug#75065: Upon archive download failure print the original error Konstantin Kharlamov
2024-12-26 8:55 ` Eli Zaretskii
2024-12-26 18:13 ` Philip Kaludercic
2024-12-26 18:17 ` Konstantin Kharlamov
2024-12-26 18:31 ` Philip Kaludercic
2024-12-26 19:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-12-26 20:14 ` Konstantin Kharlamov
2024-12-26 20:32 ` Stefan Kangas
2024-12-26 20:37 ` Konstantin Kharlamov
2024-12-26 20:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-26 20:51 ` Konstantin Kharlamov
2024-12-26 20:53 ` Konstantin Kharlamov
2024-12-26 21:03 ` Konstantin Kharlamov
2024-12-27 7:22 ` Eli Zaretskii
2024-12-27 17:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-27 18:34 ` Konstantin Kharlamov
2024-12-28 3:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7c7mtg2x.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=75065@debbugs.gnu.org \
--cc=Hi-Angel@yandex.ru \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).