unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: bug-gnu-emacs@gnu.org, 720@emacsbugs.donarmstrong.com,
	flitterio@gmail.com
Subject: bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2.
Date: Fri, 15 Aug 2008 15:31:49 -0400	[thread overview]
Message-ID: <jwv63q2cbys.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <umyjffix4.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Aug 2008 23:20:07 +0300")

>> > When building CVS Emacs on Windows XP SP2 using Visual Studio 6.0, the
>> > following patch is needed to prevent the compiler from displaying an
>> > error about unsigned __int64 not being convertable to double.
>> Wouldn't it be better to cast to (double) ?
> Wouldn't that be doing the same mistake?  The compiler probably has a
> point: an unsigned 64-bit number has more bits than a simple double
> can handle.

Yes, it's a good reason for not doing the conversion automatically, but
IIUC we need a double, so we don't have much of a choice, and that's
what the cast to (double) would tell the compiler.


        Stefan






  reply	other threads:[~2008-08-15 19:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <uskt6dvo2.fsf@gnu.org>
2008-08-14 16:57 ` bug#720: Patch to fix CVS Emacs compilation error on Windows XP SP2 Francis Litterio
2008-08-14 19:24   ` Eli Zaretskii
2008-08-14 19:54   ` Stefan Monnier
2008-08-14 20:20     ` Eli Zaretskii
2008-08-15 19:31       ` Stefan Monnier [this message]
     [not found]   ` <mailman.16704.1218743250.18990.bug-gnu-emacs@gnu.org>
2008-08-14 20:15     ` Francis Litterio
2008-08-15  8:22       ` Eli Zaretskii
2008-08-15 19:34         ` Stefan Monnier
     [not found]       ` <mailman.16768.1218790062.18990.bug-gnu-emacs@gnu.org>
2008-08-15 13:22         ` Francis Litterio
2008-08-15 16:15           ` Eli Zaretskii
2008-08-15 17:11             ` Fran Litterio
2008-08-15 17:37               ` Eli Zaretskii
2008-08-15 17:45   ` bug#720: marked as done (Patch to fix CVS Emacs compilation error on Windows XP SP2.) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv63q2cbys.fsf-monnier+emacsbugreports@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=720@emacsbugs.donarmstrong.com \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=eliz@gnu.org \
    --cc=flitterio@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).