* bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error @ 2008-10-19 15:12 ` Eli Zaretskii 2008-10-21 2:50 ` Glenn Morris 2008-10-22 6:55 ` bug#1205: marked as done (23.0.60; C-x RET c FOO C-x C-g signals an error) Emacs bug Tracking System 0 siblings, 2 replies; 10+ messages in thread From: Eli Zaretskii @ 2008-10-19 15:12 UTC (permalink / raw) To: emacs-pretest-bug Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: emacs -Q C-x RET c utf-8 RET C-x C-g produces an unexpected error message: Wrong type argument: commandp, nil (What happened here is that I changed my mind after typing the second C-x and wanted to bail out. I expected to see "Quit", not an error.) The problem happens no matter what coding-system you use instead of utf-8. If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file d:/gnu/emacs/etc/DEBUG for instructions. In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2008-10-19 on HOME-C4E4A596F7 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: ENU value of $XMODIFIERS: nil locale-coding-system: cp1255 default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: shell-dirtrack-mode: t tooltip-mode: t tool-bar-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: <down> <down> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <C-right> <C-right> <C-right> <C-right> <C-right> <C-right> <C-right> <C-right> <C-right> <left> <left> <left> <left> <left> r C-x C-s C-x C-x C-g <up> <up> <up> <up> <up> <up> <up> <up> <C-left> <C-left> C-r C-w C-w C-w C-r C-s C-s <prior> <prior> <next> <prior> <next> <next> <prior> <prior> <next> <next> M-x s h e l l - c o m m <tab> <return> l s <tab> . e <tab> d : / g <tab> n <tab> C-h c <tab> e m <tab> SPC C-g M-! l s C-h c <tab> C-g C-h f m i n i b u f f e r - c o m p l e t e - s h e <tab> <return> C-x C-x C-g <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <up> <up> <up> <up> C-r m i n i b C-g C-x o C-x o C-SPC C-x o <down> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <return> C-g <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <down> <down> <up> <down> <down> <down> <down> <down> <down> <down> <down> <C-left> <left> <left> C-h v <return> C-M-v C-x o <prior> <up> <up> <up> <up> <up> <up> <up> <up> <up> <help-echo> <help-echo> <help-echo> M-! l s SPC d : / g n <tab> e m a <tab> / l i s <tab> <left> <left> <left> <left> <left> <tab> <down-mouse-2> <mouse-2> <C-left> <C-left> <C-left> C-SPC <C-right> <C-right> <C-right> <C-right> C-g C-x o C-x <return> c u t f - 8 <return> C-x C-g <help-echo> M-x r e p o r t - e m a <tab> <return> Recent messages: Saving file d:/gnu/emacs/lisp/simple.el... Wrote d:/gnu/emacs/lisp/simple.el Quit Mark saved where search started TAB (translated from <tab>) runs the command minibuffer-complete-shell-command Quit TAB (translated from <tab>) runs the command minibuffer-complete-shell-command Quit [3 times] Mark set Quit [2 times] universal-coding-system-argument: Wrong type argument: commandp, nil ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error 2008-10-19 15:12 ` bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error Eli Zaretskii @ 2008-10-21 2:50 ` Glenn Morris 2008-10-21 6:32 ` Eli Zaretskii 2008-10-21 8:52 ` Andreas Schwab 2008-10-22 6:55 ` bug#1205: marked as done (23.0.60; C-x RET c FOO C-x C-g signals an error) Emacs bug Tracking System 1 sibling, 2 replies; 10+ messages in thread From: Glenn Morris @ 2008-10-21 2:50 UTC (permalink / raw) To: Eli Zaretskii; +Cc: 1205 Eli Zaretskii wrote: > emacs -Q > C-x RET c utf-8 RET C-x C-g > > produces an unexpected error message: > > Wrong type argument: commandp, nil Perhaps this: *** mule-cmds.el 5 Oct 2008 19:07:03 -0000 1.341 --- mule-cmds.el 21 Oct 2008 02:52:14 -0000 *************** *** 287,292 **** --- 287,295 ---- (cmd (key-binding keyseq)) prefix) + (if (char-equal last-input-char ?\C-g) + (keyboard-quit)) + (when (memq cmd '(universal-argument digit-argument)) (call-interactively cmd) ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error 2008-10-21 2:50 ` Glenn Morris @ 2008-10-21 6:32 ` Eli Zaretskii 2008-10-21 8:52 ` Andreas Schwab 1 sibling, 0 replies; 10+ messages in thread From: Eli Zaretskii @ 2008-10-21 6:32 UTC (permalink / raw) To: Glenn Morris; +Cc: 1205 > From: Glenn Morris <rgm@gnu.org> > Cc: 1205@emacsbugs.donarmstrong.com > Date: Mon, 20 Oct 2008 22:50:46 -0400 > > Eli Zaretskii wrote: > > > emacs -Q > > C-x RET c utf-8 RET C-x C-g > > > > produces an unexpected error message: > > > > Wrong type argument: commandp, nil > > > Perhaps this: > > > *** mule-cmds.el 5 Oct 2008 19:07:03 -0000 1.341 > --- mule-cmds.el 21 Oct 2008 02:52:14 -0000 > *************** > *** 287,292 **** > --- 287,295 ---- > (cmd (key-binding keyseq)) > prefix) > > + (if (char-equal last-input-char ?\C-g) > + (keyboard-quit)) > + > (when (memq cmd '(universal-argument digit-argument)) > (call-interactively cmd) Looks correct to me. Thanks. ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error 2008-10-21 2:50 ` Glenn Morris 2008-10-21 6:32 ` Eli Zaretskii @ 2008-10-21 8:52 ` Andreas Schwab 2008-10-22 2:42 ` Kevin Rodgers 1 sibling, 1 reply; 10+ messages in thread From: Andreas Schwab @ 2008-10-21 8:52 UTC (permalink / raw) To: Glenn Morris; +Cc: 1205 Glenn Morris <rgm@gnu.org> writes: > + (if (char-equal last-input-char ?\C-g) quit_char may not be C-g. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error 2008-10-21 8:52 ` Andreas Schwab @ 2008-10-22 2:42 ` Kevin Rodgers 2008-10-22 5:17 ` Drew Adams 0 siblings, 1 reply; 10+ messages in thread From: Kevin Rodgers @ 2008-10-22 2:42 UTC (permalink / raw) To: bug-gnu-emacs Andreas Schwab wrote: > Glenn Morris <rgm@gnu.org> writes: > >> + (if (char-equal last-input-char ?\C-g) > > quit_char may not be C-g. So ?\C-g should be expressed instead as (nth 3 (current-input-mode)), correct? -- Kevin Rodgers Denver, Colorado, USA ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error 2008-10-22 2:42 ` Kevin Rodgers @ 2008-10-22 5:17 ` Drew Adams 2008-10-22 7:05 ` Kevin Rodgers 0 siblings, 1 reply; 10+ messages in thread From: Drew Adams @ 2008-10-22 5:17 UTC (permalink / raw) To: 'Kevin Rodgers', 1205, bug-gnu-emacs > >> + (if (char-equal last-input-char ?\C-g) > > > > quit_char may not be C-g. > > So ?\C-g should be expressed instead as (nth 3 (current-input-mode)), > correct? Essentially the question I asked emacs-devel today (based on this thread, though I had forgotten where I saw it). See emacs-devel thread "question about `quit-char'", FYI. The answer I got was no, not in Emacs 23 (or 22 or 21...). Later, maybe. There was a fair amount of noise and distraction in the thread, but that's the answer I took away for this question. ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error 2008-10-22 5:17 ` Drew Adams @ 2008-10-22 7:05 ` Kevin Rodgers 2008-10-22 15:00 ` Stefan Monnier 2008-10-22 16:20 ` Drew Adams 0 siblings, 2 replies; 10+ messages in thread From: Kevin Rodgers @ 2008-10-22 7:05 UTC (permalink / raw) To: bug-gnu-emacs Drew Adams wrote: >>>> + (if (char-equal last-input-char ?\C-g) >>> quit_char may not be C-g. >> So ?\C-g should be expressed instead as (nth 3 (current-input-mode)), >> correct? > > Essentially the question I asked emacs-devel today (based on this thread, though > I had forgotten where I saw it). See emacs-devel thread "question about > `quit-char'", FYI. > > The answer I got was no, not in Emacs 23 (or 22 or 21...). Later, maybe. > > There was a fair amount of noise and distraction in the thread, but that's the > answer I took away for this question. That's not the conclusion I came to, which is: You should feel fairly confident in binding C-g as a quit character in your code, but Emacs itself should continue to fully support current-input-mode/ set-input-mode -- unless and until a decision is reached to deprecate the QUIT functionality they provide. -- Kevin Rodgers Denver, Colorado, USA ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error 2008-10-22 7:05 ` Kevin Rodgers @ 2008-10-22 15:00 ` Stefan Monnier 2008-10-22 16:20 ` Drew Adams 1 sibling, 0 replies; 10+ messages in thread From: Stefan Monnier @ 2008-10-22 15:00 UTC (permalink / raw) To: Kevin Rodgers; +Cc: 1205, bug-gnu-emacs > That's not the conclusion I came to, which is: You should feel fairly > confident in binding C-g as a quit character in your code, but > Emacs itself should continue to fully support current-input-mode/ > set-input-mode -- unless and until a decision is reached to deprecate > the QUIT functionality they provide. I believe the conclusion of thread is that we should keep doing it the simple way until either we remove the functionality or we fix all the code to support the functionality reliably. Stefan ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error 2008-10-22 7:05 ` Kevin Rodgers 2008-10-22 15:00 ` Stefan Monnier @ 2008-10-22 16:20 ` Drew Adams 1 sibling, 0 replies; 10+ messages in thread From: Drew Adams @ 2008-10-22 16:20 UTC (permalink / raw) To: 'Kevin Rodgers', 1205, bug-gnu-emacs > >>>> + (if (char-equal last-input-char ?\C-g) > >>> quit_char may not be C-g. > >> So ?\C-g should be expressed instead as (nth 3 > >> (current-input-mode)), correct? > > > > Essentially the question I asked emacs-devel today (based > > on this thread, though I had forgotten where I saw it). > > See emacs-devel thread "question about `quit-char'", FYI. > > > > The answer I got was no, not in Emacs 23 (or 22 or 21...). > > Later, maybe. > > > > There was a fair amount of noise and distraction in the > > thread, but that's the answer I took away for this question. > > That's not the conclusion I came to, which is: You should feel fairly > confident in binding C-g as a quit character in your code, but > Emacs itself should continue to fully support current-input-mode/ > set-input-mode -- unless and until a decision is reached to deprecate > the QUIT functionality they provide. OK, I didn't mean to pronounce on what Emacs would/should support, but rather to communicate the part about what users should do now in their code. My reading was not just that one can feel confident using C-g now but that that is what one should do, for now. But anyway, you've obviously read the thread, and all I wanted to do was bring it to your attention. ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#1205: marked as done (23.0.60; C-x RET c FOO C-x C-g signals an error) 2008-10-19 15:12 ` bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error Eli Zaretskii 2008-10-21 2:50 ` Glenn Morris @ 2008-10-22 6:55 ` Emacs bug Tracking System 1 sibling, 0 replies; 10+ messages in thread From: Emacs bug Tracking System @ 2008-10-22 6:55 UTC (permalink / raw) To: Glenn Morris [-- Attachment #1: Type: text/plain, Size: 872 bytes --] Your message dated Wed, 22 Oct 2008 02:45:23 -0400 with message-id <dahc75dt6k.fsf@fencepost.gnu.org> and subject line Re: bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error has caused the Emacs bug report #1205, regarding 23.0.60; C-x RET c FOO C-x C-g signals an error to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) -- 1205: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1205 Emacs Bug Tracking System Contact don@donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 5586 bytes --] From: Eli Zaretskii <eliz@gnu.org> To: emacs-pretest-bug@gnu.org Subject: 23.0.60; C-x RET c FOO C-x C-g signals an error Date: Sun, 19 Oct 2008 17:12:33 +0200 Message-ID: <utzb8k49q.fsf@gnu.org> Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: emacs -Q C-x RET c utf-8 RET C-x C-g produces an unexpected error message: Wrong type argument: commandp, nil (What happened here is that I changed my mind after typing the second C-x and wanted to bail out. I expected to see "Quit", not an error.) The problem happens no matter what coding-system you use instead of utf-8. If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file d:/gnu/emacs/etc/DEBUG for instructions. In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2008-10-19 on HOME-C4E4A596F7 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: ENU value of $XMODIFIERS: nil locale-coding-system: cp1255 default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: shell-dirtrack-mode: t tooltip-mode: t tool-bar-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: <down> <down> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <C-right> <C-right> <C-right> <C-right> <C-right> <C-right> <C-right> <C-right> <C-right> <left> <left> <left> <left> <left> r C-x C-s C-x C-x C-g <up> <up> <up> <up> <up> <up> <up> <up> <C-left> <C-left> C-r C-w C-w C-w C-r C-s C-s <prior> <prior> <next> <prior> <next> <next> <prior> <prior> <next> <next> M-x s h e l l - c o m m <tab> <return> l s <tab> . e <tab> d : / g <tab> n <tab> C-h c <tab> e m <tab> SPC C-g M-! l s C-h c <tab> C-g C-h f m i n i b u f f e r - c o m p l e t e - s h e <tab> <return> C-x C-x C-g <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <up> <up> <up> <up> C-r m i n i b C-g C-x o C-x o C-SPC C-x o <down> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <right> <return> C-g <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <down> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <down> <down> <up> <down> <down> <down> <down> <down> <down> <down> <down> <C-left> <left> <left> C-h v <return> C-M-v C-x o <prior> <up> <up> <up> <up> <up> <up> <up> <up> <up> <help-echo> <help-echo> <help-echo> M-! l s SPC d : / g n <tab> e m a <tab> / l i s <tab> <left> <left> <left> <left> <left> <tab> <down-mouse-2> <mouse-2> <C-left> <C-left> <C-left> C-SPC <C-right> <C-right> <C-right> <C-right> C-g C-x o C-x <return> c u t f - 8 <return> C-x C-g <help-echo> M-x r e p o r t - e m a <tab> <return> Recent messages: Saving file d:/gnu/emacs/lisp/simple.el... Wrote d:/gnu/emacs/lisp/simple.el Quit Mark saved where search started TAB (translated from <tab>) runs the command minibuffer-complete-shell-command Quit TAB (translated from <tab>) runs the command minibuffer-complete-shell-command Quit [3 times] Mark set Quit [2 times] universal-coding-system-argument: Wrong type argument: commandp, nil [-- Attachment #3: Type: message/rfc822, Size: 1693 bytes --] From: Glenn Morris <rgm@gnu.org> To: 1205-done@emacsbugs.donarmstrong.com Subject: Re: bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error Date: Wed, 22 Oct 2008 02:45:23 -0400 Message-ID: <dahc75dt6k.fsf@fencepost.gnu.org> 2008-10-22 Glenn Morris <rgm@gnu.org> * international/mule-cmds.el (universal-coding-system-argument): Check for C-g. (Bug#1205) ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2008-10-22 16:20 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <dahc75dt6k.fsf@fencepost.gnu.org>
2008-10-19 15:12 ` bug#1205: 23.0.60; C-x RET c FOO C-x C-g signals an error Eli Zaretskii
2008-10-21 2:50 ` Glenn Morris
2008-10-21 6:32 ` Eli Zaretskii
2008-10-21 8:52 ` Andreas Schwab
2008-10-22 2:42 ` Kevin Rodgers
2008-10-22 5:17 ` Drew Adams
2008-10-22 7:05 ` Kevin Rodgers
2008-10-22 15:00 ` Stefan Monnier
2008-10-22 16:20 ` Drew Adams
2008-10-22 6:55 ` bug#1205: marked as done (23.0.60; C-x RET c FOO C-x C-g signals an error) Emacs bug Tracking System
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).