From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: 3142@emacsbugs.donarmstrong.com,
Jared Finder <jfinder@crypticstudios.com>
Subject: bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically
Date: Thu, 30 Apr 2009 14:20:58 -0400 [thread overview]
Message-ID: <jwv63gm2egb.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <87ljpiuyi0.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 30 Apr 2009 14:47:27 +0300")
>> + (defcustom split-window-preferred-function 'split-selected-window
>> + "Function called by `display-buffer' to split a window.
>> + The window that shall be split is selected when this function is
>> + called. The function is supposed to either return the new window
>> + or nil if the window can (or shall) not be split."
>> + :type 'function
>> + :version "23.1"
>> + :group 'windows)
> If setting this option to `split-window-horizontally' and
> `split-window-vertically' is possible and it works correctly
> with these value, then I suggest adding them as constants,
> e.g. "Always split horizontally" and "Always split vertically".
Agreed (does :options work in such a case?).
> Also I suggest keeping the common function name prefix
> "split-window-",
Yes, please.
> i.e. instead of `split-selected-window' to name it something like
> "split-window-sensibly" or "split-window-with-thresholds".
Or split-window-dwim, split-window-somehow.
Stefan
PS: Other than that, the code looks fine.
next prev parent reply other threads:[~2009-04-30 18:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 1:16 bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically Jared Finder
2009-04-28 6:29 ` martin rudalics
2009-04-28 17:21 ` Jared Finder
2009-04-28 22:48 ` Juri Linkov
2009-04-29 1:29 ` Stefan Monnier
2009-04-29 7:13 ` martin rudalics
2009-04-29 9:59 ` Juri Linkov
2009-04-29 12:40 ` martin rudalics
2009-04-29 13:50 ` bug#3142: 23.0.92; split-window-prefered-function should be able to usesplit-window-horizontally/split-window-vertically Drew Adams
2009-04-30 9:05 ` martin rudalics
2011-10-05 18:49 ` Glenn Morris
2011-10-05 22:11 ` Stefan Monnier
2009-04-29 15:26 ` bug#3142: 23.0.92; split-window-prefered-function should be able to use split-window-horizontally/split-window-vertically Stefan Monnier
2009-04-30 8:54 ` martin rudalics
2009-04-30 11:47 ` Juri Linkov
2009-04-30 18:20 ` Stefan Monnier [this message]
2009-05-01 11:54 ` Juri Linkov
2009-05-01 8:33 ` martin rudalics
2009-05-01 11:52 ` Juri Linkov
2009-05-02 8:40 ` martin rudalics
2009-05-05 7:02 ` martin rudalics
2009-05-05 11:03 ` Juri Linkov
2009-05-06 1:41 ` Stefan Monnier
2009-05-06 16:21 ` martin rudalics
2009-05-06 19:04 ` Stefan Monnier
2009-05-07 9:36 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv63gm2egb.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=3142@emacsbugs.donarmstrong.com \
--cc=jfinder@crypticstudios.com \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).