unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 7591@debbugs.gnu.org
Subject: bug#7591: 24.0.50; incorrect `make-obsolete' for `mouse-major-mode-menu'
Date: Fri, 10 Dec 2010 16:01:47 -0500	[thread overview]
Message-ID: <jwv62v15otc.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <612738B99E514F4084A6029D9CD79436@us.oracle.com> (Drew Adams's message of "Fri, 10 Dec 2010 08:46:09 -0800")

>> The argument to make-obsolete is not intended to say "foobar is
>> a drop-in-replacement for barbaz", just that "barbaz has been found
>> undesirable, its successor is foobar".  Often one needs to 
>> adjust things if one wants to switch to the new non-obsolete
>> alternative.
> Even if that is the case it is not helpful here.  The best command to use for
> this is the _only_ command that exists (so far): `mouse-major-mode-menu'.

Right, so you "need to adjust things".  This case really doesn't seem to
be any different.

> Unless there is a _command_ that does what `mouse-major-mode-menu' does, you
> cannot do something like that.

No part of Emacs needs such a command, and very few users (or external
packages) would use it.  So I'm far from convinced it is warranted.

> Or you need to roll your own command.

Exactly.  Something along lines of

  (defun my-command ()
    (x-popup-menu nil mouse-menu-major-mode-map))

should do the trick.
    
> Emacs should offer a command for this, as it has in the past.  What is wrong
> with the existing `mouse-major-mode-menu' that it should be removed?

mouse-menu-major-mode-map works as well or better (better because C-h
k can be used to find the name of a function bound to a particular menu
entry) for all uses we care about.  So we don't need
mouse-major-mode-menu any more.


        Stefan





      reply	other threads:[~2010-12-10 21:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08 16:17 bug#7591: 24.0.50; incorrect `make-obsolete' for `mouse-major-mode-menu' Drew Adams
2010-12-09 22:52 ` Stefan Monnier
2010-12-10 16:46   ` Drew Adams
2010-12-10 21:01     ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv62v15otc.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=7591@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).