From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#8941: which-func-ff-hook should be less noisy Date: Mon, 04 Jul 2011 16:42:20 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1309812212 16256 80.91.229.12 (4 Jul 2011 20:43:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 4 Jul 2011 20:43:32 +0000 (UTC) Cc: 8941@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 04 22:43:28 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QdpzK-0005C2-OT for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jul 2011 22:43:26 +0200 Original-Received: from localhost ([::1]:41889 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QdpzJ-00064W-NP for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jul 2011 16:43:25 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:38436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qdpz0-000646-Aa for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2011 16:43:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qdpyy-0000w4-EK for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2011 16:43:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qdpyx-0000vm-WE for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2011 16:43:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Qdpyw-00085a-Ak; Mon, 04 Jul 2011 16:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jul 2011 20:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8941 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8941-submit@debbugs.gnu.org id=B8941.130981215331054 (code B ref 8941); Mon, 04 Jul 2011 20:43:02 +0000 Original-Received: (at 8941) by debbugs.gnu.org; 4 Jul 2011 20:42:33 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdpyT-00084p-8i for submit@debbugs.gnu.org; Mon, 04 Jul 2011 16:42:33 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QdpyQ-00084V-D9 for 8941@debbugs.gnu.org; Mon, 04 Jul 2011 16:42:31 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EABEkEk5FxIxr/2dsb2JhbABTp3t4iHrBJoY2BJ5chCw X-IronPort-AV: E=Sophos;i="4.65,475,1304308800"; d="scan'208";a="120418436" Original-Received: from 69-196-140-107.dsl.teksavvy.com (HELO pastel.home) ([69.196.140.107]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 04 Jul 2011 16:42:23 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 3092358DBA; Mon, 4 Jul 2011 16:42:20 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Mon, 27 Jun 2011 14:03:16 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 04 Jul 2011 16:43:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47993 Archived-At: > @@ -207,6 +207,7 @@ > (setq imenu--index-alist > (save-excursion (funcall imenu-create-index-function)))) > (error > + (message "which-func-ff-hook error: %S" err) > (setq which-func-mode nil)))) > which "logs" the error message. Unfortunately, when you have > `which-func-modes' set to t, you receive that message a lot for what > it is not an error (which-func-mode is simply unsupported in that > buffer / mode). Hmm... that's a problem. > I don't want to remove it, because I suppose Stefan put it for a > reason. Now, if the reason is simply to log the error in *Messages*, > either doing it directly, or conditionalizing it somehow according to > (eq which-func-modes t) would be better. The intention is to make sure errors in Imenu don't get ignored silently, otherwise diagnosing problems can be difficult. But of course, we need to distinguish between "we got an error because Imenu is not supported in this buffer" and real errors. Sadly, imenu does not make it easy to figure out whether it is enabled/configured in a given buffer. You'd have to check - imenu-create-index-function - imenu-prev-index-position-function and imenu-extract-index-name-function - imenu--generic-function - imenu-generic-expression Would the patch below work? === modified file 'lisp/progmodes/which-func.el' --- lisp/progmodes/which-func.el 2011-05-12 07:07:06 +0000 +++ lisp/progmodes/which-func.el 2011-07-04 20:42:04 +0000 @@ -206,7 +206,8 @@ (setq imenu--index-alist (save-excursion (funcall imenu-create-index-function)))) (error - (message "which-func-ff-hook error: %S" err) + (unless (equal err (error "This buffer cannot use `imenu-default-create-index-function'")) + (message "which-func-ff-hook error: %S" err)) (setq which-func-mode nil)))) (defun which-func-update ()