From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#8084: 24.0.50; grep still relies on font-lock somewhat Date: Tue, 06 Sep 2011 14:42:53 -0400 Message-ID: References: <87vd0fmqcp.fsf@gnus.org> <8762sdwxr6.fsf@gnus.org> <87pqkdum14.fsf@mail.jurta.org> <87zkijqpxk.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1315334608 8871 80.91.229.12 (6 Sep 2011 18:43:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 6 Sep 2011 18:43:28 +0000 (UTC) To: 8084@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 06 20:43:24 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R10cE-0000XJ-LM for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2011 20:43:22 +0200 Original-Received: from localhost ([::1]:56154 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R10cD-0002Zw-HA for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Sep 2011 14:43:21 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:48845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R10cA-0002Zg-EZ for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 14:43:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R10c6-00037O-Ep for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 14:43:18 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R10c6-00037K-Cp for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2011 14:43:14 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R10fm-0001vH-8c; Tue, 06 Sep 2011 14:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2011 18:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8084 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8084-submit@debbugs.gnu.org id=B8084.13153348047368 (code B ref 8084); Tue, 06 Sep 2011 18:47:02 +0000 Original-Received: (at 8084) by debbugs.gnu.org; 6 Sep 2011 18:46:44 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R10fU-0001un-6k for submit@debbugs.gnu.org; Tue, 06 Sep 2011 14:46:44 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R10fS-0001uf-Sz for 8084@debbugs.gnu.org; Tue, 06 Sep 2011 14:46:43 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id p86IgrMZ032378; Tue, 6 Sep 2011 14:42:53 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id B2BED1300D2; Tue, 6 Sep 2011 14:42:53 -0400 (EDT) In-Reply-To: <87zkijqpxk.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 05 Sep 2011 12:49:43 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3972=0 X-NAI-Spam-Version: 2.2.0.9286 : core <3972> : streams <679106> : uri <952945> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 06 Sep 2011 14:47:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50642 Archived-At: > I now think that `grep-process-setup' should still check for > `(null font-lock-mode)' to not output color escapes > that can't be highlighted with `font-lock-face' by `grep-filter'. > There is no harm to output color escapes because `grep-filter' > still removes them, but this is useless because text properties > `font-lock-face' can't be displayed when `font-lock-mode' is nil. The (null font-lock-mode) test is an optimization. It may provide more reliable and slightly faster behavior for those people who don't want the highlighting. It does come with one downside, which is that enabling font-lock-mode after the fact will not result in the matches being highlighted. I'm not too worried about this downside, so either way is fine by me. Stefan