From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: 8084@debbugs.gnu.org
Subject: bug#8084: 24.0.50; grep still relies on font-lock somewhat
Date: Tue, 06 Sep 2011 14:42:53 -0400 [thread overview]
Message-ID: <jwv62l5a502.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87zkijqpxk.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 05 Sep 2011 12:49:43 +0300")
> I now think that `grep-process-setup' should still check for
> `(null font-lock-mode)' to not output color escapes
> that can't be highlighted with `font-lock-face' by `grep-filter'.
> There is no harm to output color escapes because `grep-filter'
> still removes them, but this is useless because text properties
> `font-lock-face' can't be displayed when `font-lock-mode' is nil.
The (null font-lock-mode) test is an optimization. It may provide more
reliable and slightly faster behavior for those people who don't want
the highlighting.
It does come with one downside, which is that enabling font-lock-mode
after the fact will not result in the matches being highlighted.
I'm not too worried about this downside, so either way is fine by me.
Stefan
next prev parent reply other threads:[~2011-09-06 18:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-20 1:44 bug#8084: 24.0.50; Grep output not usable in Ubuntu Lars Magne Ingebrigtsen
2011-02-21 9:00 ` Glenn Morris
2011-02-21 9:19 ` Lars Ingebrigtsen
2011-02-21 21:44 ` Glenn Morris
2011-02-21 22:46 ` Andreas Schwab
2011-08-10 19:03 ` bug#8084: 24.0.50; grep still relies on font-lock somewhat Juri Linkov
2011-09-05 9:49 ` Juri Linkov
2011-09-06 18:42 ` Stefan Monnier [this message]
2011-02-21 21:44 ` bug#8084: 24.0.50; Grep output not usable in Ubuntu Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv62l5a502.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=8084@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).