From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Glenn Morris <rgm@gnu.org>
Cc: Richard Copley <rcopley@gmail.com>, 10133@debbugs.gnu.org
Subject: bug#10133: (24.0.91; mark-active)
Date: Tue, 29 Nov 2011 08:52:30 -0500 [thread overview]
Message-ID: <jwv62i39gz7.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <u962i3k59b.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 28 Nov 2011 21:54:24 -0500")
>> I guess the bug is that the functions in "log-view.el" should be using
>> `use-region-p' or `region-active-p' rather than `mark-active'.
> Why? That would make them dependent on transient mark mode.
But the current behavior means that without transient-mark-mode, if
you've set the mark at some point in the past, you can't do a "diff with
current file" any more, only a "diff between revision at point and
revision at mark".
> Nowhere in the doc of eg log-view-diff does it say that the function
> behaves differently if transient mark mode is on. So I don't see that
> there is a bug here.
It's maybe not a bug, but it's a limitation.
I think `use-region-p' would make a lot of sense here nowadays (there
was no temporary tmm back when I wrote the code, so something like
use-region-p would have made the "diff between 2 revisions"
inaccessible to non-tmm users, but this limit has now been lifted).
Stefan
next prev parent reply other threads:[~2011-11-29 13:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 14:15 bug#10133: 24.0.91; mark-active Richard Copley
2011-11-25 14:30 ` bug#10133: (24.0.91; mark-active) Richard Copley
2011-11-29 2:54 ` Glenn Morris
2011-11-29 13:52 ` Stefan Monnier [this message]
2011-11-29 17:27 ` Glenn Morris
2012-08-09 7:50 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv62i39gz7.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=10133@debbugs.gnu.org \
--cc=rcopley@gmail.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).