From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13023: 24.3.50; lexical binding does not work within defadvice Date: Thu, 29 Nov 2012 22:45:01 -0500 Message-ID: References: <87zk213do1@ch.ristopher.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1354247163 14700 80.91.229.3 (30 Nov 2012 03:46:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 30 Nov 2012 03:46:03 +0000 (UTC) Cc: 13023@debbugs.gnu.org To: rms@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 30 04:46:15 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TeHYM-0004LG-UW for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Nov 2012 04:46:15 +0100 Original-Received: from localhost ([::1]:38960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeHYB-0008Gg-Ir for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Nov 2012 22:46:03 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeHY8-0008Ei-Ez for bug-gnu-emacs@gnu.org; Thu, 29 Nov 2012 22:46:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TeHY7-00012T-HX for bug-gnu-emacs@gnu.org; Thu, 29 Nov 2012 22:46:00 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeHY7-00012N-E9 for bug-gnu-emacs@gnu.org; Thu, 29 Nov 2012 22:45:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TeHa6-0005XS-5X for bug-gnu-emacs@gnu.org; Thu, 29 Nov 2012 22:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Nov 2012 03:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13023 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13023-submit@debbugs.gnu.org id=B13023.135424723121229 (code B ref 13023); Fri, 30 Nov 2012 03:48:02 +0000 Original-Received: (at 13023) by debbugs.gnu.org; 30 Nov 2012 03:47:11 +0000 Original-Received: from localhost ([127.0.0.1]:45832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TeHZH-0005WL-79 for submit@debbugs.gnu.org; Thu, 29 Nov 2012 22:47:11 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:35561) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TeHZC-0005WC-7N for 13023@debbugs.gnu.org; Thu, 29 Nov 2012 22:47:06 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxKh9/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDYhABboJjSaDHgOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="208794368" Original-Received: from 69-196-168-125.dsl.teksavvy.com (HELO pastel.home) ([69.196.168.125]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 29 Nov 2012 22:45:02 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id C3D1A59069; Thu, 29 Nov 2012 22:45:01 -0500 (EST) In-Reply-To: (Richard Stallman's message of "Thu, 29 Nov 2012 17:50:02 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67635 > Indeed, it doesn't work. And because of the way advice.el works > (building a new function by combining the code chunks from all the > pieces of advice applied to that function) it's not easy to fix. > Would it be possible to fix this by defining a new primitive construct > for use in the constructed function that runs the advice? I don't think there's a need to add any new primitive. If someone wants to dig into advice.el to try and fix it, it can be fixed there (as evidenced by advice-add). I personally would rather tell people to use advice-add instead. Stefan