From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13207: lisp-mnt.el improvements Date: Mon, 17 Dec 2012 12:58:48 -0500 Message-ID: References: <878v8wve4m.fsf@bernoul.li> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1355767197 24176 80.91.229.3 (17 Dec 2012 17:59:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 17 Dec 2012 17:59:57 +0000 (UTC) Cc: 13207@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 17 19:00:11 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tkez4-0002yS-PY for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Dec 2012 19:00:10 +0100 Original-Received: from localhost ([::1]:48858 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tkeyr-0000Eu-Jl for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Dec 2012 12:59:57 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tkeyl-0000El-1s for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 12:59:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tkeyg-00087i-TZ for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 12:59:50 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tkeyg-00087e-Qk for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 12:59:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tkezu-0006mo-5U for bug-gnu-emacs@gnu.org; Mon, 17 Dec 2012 13:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Dec 2012 18:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13207 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13207-submit@debbugs.gnu.org id=B13207.135576721526032 (code B ref 13207); Mon, 17 Dec 2012 18:01:02 +0000 Original-Received: (at 13207) by debbugs.gnu.org; 17 Dec 2012 18:00:15 +0000 Original-Received: from localhost ([127.0.0.1]:47477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tkez5-0006ll-2x for submit@debbugs.gnu.org; Mon, 17 Dec 2012 13:00:15 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:46881) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tkeyz-0006lD-Dr for 13207@debbugs.gnu.org; Mon, 17 Dec 2012 13:00:10 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FxLDj/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLNBIUGA0kE4gJBboJkEQDiEKacYFYgwc X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="210096026" Original-Received: from 69-196-176-227.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.227]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 17 Dec 2012 12:58:48 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 7800C5912C; Mon, 17 Dec 2012 12:58:48 -0500 (EST) In-Reply-To: <878v8wve4m.fsf@bernoul.li> (Jonas Bernoulli's message of "Mon, 17 Dec 2012 17:26:33 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68654 Archived-At: > 1. Add function lm-homepage > (lm-header "\\(?:x-\\)?\\(?:homepage\\|url\\)") > These keywords are used quite often, most often without the X- prefix. Sounds OK. > 2. lm-section-end: the end is now always before the following > non-comment text > Many people don't add ;;; Code: after the header. As a result > lm-commentary was often way of (like eof!) and lm-commentary returned > text that isn't part of the commentary but code. Good. > 3. lm-header, lm-header-multiline: wrap with save-match-data This one doesn't sound right. The callers should be fixed instead. > 4. lm-header-multiline: continuation lines now need to be intended more > than the first line. E.g: > ;; Keyword: value > ;; more value > This is necessary because some built-in libraries contain things > like: > ;; Author: Kenichi HANDA > ;; (according to ack.texi) > And some third-party libraries contain things like: > ;; Keywords: key words > ;; This file is not part of Emacs > Among the 3500 packages mirrored on the Emacsmirror there are only > three where this change results in lines intended as continuation > lines not to be recognised anymore. At the same time this change > fixes ~50 errors. An important measure is how much breakage/improvement does it introduce when applied to files that are expected to do thing right (e.g. files in emacs/lisp and in elpa/packages). I'm OK with making lisp-mnt.el more forgiving, but it should not come at the cost of those packages that do things right. Stefan