From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17809: 24.4.50; Completions display Date: Sun, 06 Jul 2014 00:32:46 -0400 Message-ID: References: <87tx7buryg.fsf@mail.jurta.org> <53A92532.9040901@gmx.at> <87y4wlg8gx.fsf_-_@mail.jurta.org> <53AA7222.1010905@gmx.at> <8738er89q6.fsf@mail.jurta.org> <53AD12AE.2050707@gmx.at> <877g41vp5x.fsf@mail.jurta.org> <53AE7A3A.20307@gmx.at> <87mwcowxfs.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1404621210 8610 80.91.229.3 (6 Jul 2014 04:33:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Jul 2014 04:33:30 +0000 (UTC) Cc: 17809@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 06 06:33:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X3e8f-0005tX-OO for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Jul 2014 06:33:21 +0200 Original-Received: from localhost ([::1]:44666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3e8f-0007t3-5S for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Jul 2014 00:33:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3e8V-0007s0-OW for bug-gnu-emacs@gnu.org; Sun, 06 Jul 2014 00:33:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3e8O-0007QO-5r for bug-gnu-emacs@gnu.org; Sun, 06 Jul 2014 00:33:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3e8O-0007QK-3k for bug-gnu-emacs@gnu.org; Sun, 06 Jul 2014 00:33:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X3e8N-0004S0-IS for bug-gnu-emacs@gnu.org; Sun, 06 Jul 2014 00:33:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Jul 2014 04:33:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17809-submit@debbugs.gnu.org id=B17809.140462117617080 (code B ref 17809); Sun, 06 Jul 2014 04:33:03 +0000 Original-Received: (at 17809) by debbugs.gnu.org; 6 Jul 2014 04:32:56 +0000 Original-Received: from localhost ([127.0.0.1]:44460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3e8G-0004RP-9q for submit@debbugs.gnu.org; Sun, 06 Jul 2014 00:32:56 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:22662) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3e8C-0004Qy-HV for 17809@debbugs.gnu.org; Sun, 06 Jul 2014 00:32:53 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giYBAQRWIxALNBIUGA0kiAzSGReOegeEOASpGYFqg0wh X-IPAS-Result: ArYGAIDvNVNLd+D9/2dsb2JhbABZgwaDSr0vgw6BFxd0giYBAQRWIxALNBIUGA0kiAzSGReOegeEOASpGYFqg0wh X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="76531911" Original-Received: from 75-119-224-253.dsl.teksavvy.com (HELO ceviche.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Jul 2014 00:32:46 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id CE44E66090; Sun, 6 Jul 2014 00:32:46 -0400 (EDT) In-Reply-To: <87mwcowxfs.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 05 Jul 2014 02:40:31 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91232 Archived-At: > +(defmacro with-displayed-buffer-window (buffer-or-name action quit-function &rest body) That looks OK. Two details, tho: > + (setq ,window (temp-buffer-window-show ,buffer ,action))) [...] > + (when (functionp (cdr (assq 'window-height (cdr ,action)))) Let's not evaluate `action' twice. I.e. we need a (macroexp-let2 ..) wrapper for it. > + (if (functionp ,quit-function) > + (funcall ,quit-function ,window ,value) Same for quit-function, and additionally, we want to make sure we evaluate `quit-function' before `body'. Stefan