From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: 17809@debbugs.gnu.org
Subject: bug#17809: 24.4.50; Completions display
Date: Sun, 06 Jul 2014 00:32:46 -0400 [thread overview]
Message-ID: <jwv61jb5cv0.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87mwcowxfs.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 05 Jul 2014 02:40:31 +0300")
> +(defmacro with-displayed-buffer-window (buffer-or-name action quit-function &rest body)
That looks OK. Two details, tho:
> + (setq ,window (temp-buffer-window-show ,buffer ,action)))
[...]
> + (when (functionp (cdr (assq 'window-height (cdr ,action))))
Let's not evaluate `action' twice. I.e. we need a (macroexp-let2 ..)
wrapper for it.
> + (if (functionp ,quit-function)
> + (funcall ,quit-function ,window ,value)
Same for quit-function, and additionally, we want to make sure we
evaluate `quit-function' before `body'.
Stefan
next prev parent reply other threads:[~2014-07-06 4:32 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-22 13:30 bug#17831: 24.4.50; bad default value for `Man-width' Leo Liu
2014-06-23 12:53 ` Stefan Monnier
2014-06-23 23:17 ` Juri Linkov
2014-06-24 1:26 ` Stefan Monnier
2014-06-24 7:13 ` martin rudalics
2014-06-24 12:53 ` Stefan Monnier
2014-06-24 15:55 ` Eli Zaretskii
2014-06-24 17:33 ` Stefan Monnier
2014-06-24 17:59 ` Eli Zaretskii
2014-06-25 6:54 ` martin rudalics
2014-06-24 15:46 ` Eli Zaretskii
2014-06-24 17:31 ` Stefan Monnier
2014-06-24 17:56 ` Eli Zaretskii
2014-06-24 19:35 ` Stefan Monnier
2014-06-24 20:06 ` Eli Zaretskii
2014-06-24 20:29 ` Stefan Monnier
2014-06-24 23:48 ` Juri Linkov
2014-06-25 3:11 ` Stefan Monnier
2014-06-26 23:49 ` Juri Linkov
2014-06-27 2:16 ` Stefan Monnier
2014-06-27 23:45 ` Juri Linkov
2014-06-28 1:30 ` Stefan Monnier
2014-06-29 23:42 ` Juri Linkov
2014-06-30 3:29 ` Stefan Monnier
2014-06-24 23:42 ` Juri Linkov
2014-06-25 6:54 ` martin rudalics
2014-06-24 23:44 ` bug#17809: 24.4.50; Completions display Juri Linkov
2014-06-25 6:54 ` martin rudalics
2014-06-26 23:41 ` Juri Linkov
2014-06-27 2:07 ` Stefan Monnier
2014-06-27 6:43 ` martin rudalics
2014-06-27 23:54 ` Juri Linkov
2014-06-28 8:18 ` martin rudalics
2014-06-29 23:47 ` Juri Linkov
2014-07-01 23:30 ` Juri Linkov
2014-07-04 23:40 ` Juri Linkov
2014-07-06 4:32 ` Stefan Monnier [this message]
2014-07-06 23:32 ` Juri Linkov
2014-07-07 1:21 ` Stefan Monnier
2014-07-07 1:24 ` Stefan Monnier
2014-07-07 6:49 ` Juri Linkov
2014-07-08 3:43 ` Stefan Monnier
2014-07-08 8:03 ` Juri Linkov
2014-06-27 6:43 ` martin rudalics
2014-06-27 23:53 ` Juri Linkov
2014-06-28 8:17 ` martin rudalics
2014-06-23 23:21 ` bug#17831: 24.4.50; bad default value for `Man-width' Leo Liu
-- strict thread matches above, loose matches on Subject: below --
2014-06-19 6:57 bug#17809: 24.4.50; Completions display Juri Linkov
2014-06-23 23:53 ` Juri Linkov
2014-10-05 22:02 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv61jb5cv0.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=17809@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).