From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20491: 25.0.50; new eieio-oref implementation Date: Sun, 03 May 2015 21:44:33 -0400 Message-ID: References: <20150503.072916.112599561183374401.devel@pollock-nageoire.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1430703925 21741 80.91.229.3 (4 May 2015 01:45:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 May 2015 01:45:25 +0000 (UTC) Cc: zappo@gnu.org, 20491@debbugs.gnu.org To: Pierre Lorenzon Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 04 03:45:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yp5RY-0004ft-La for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 May 2015 03:45:12 +0200 Original-Received: from localhost ([::1]:60726 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yp5RX-0006zT-VL for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 May 2015 21:45:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yp5RV-0006zN-0x for bug-gnu-emacs@gnu.org; Sun, 03 May 2015 21:45:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yp5RQ-0003HE-U4 for bug-gnu-emacs@gnu.org; Sun, 03 May 2015 21:45:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yp5RQ-0003GF-QS for bug-gnu-emacs@gnu.org; Sun, 03 May 2015 21:45:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Yp5RQ-0004yY-2n for bug-gnu-emacs@gnu.org; Sun, 03 May 2015 21:45:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 May 2015 01:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20491 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20491-submit@debbugs.gnu.org id=B20491.143070388119078 (code B ref 20491); Mon, 04 May 2015 01:45:03 +0000 Original-Received: (at 20491) by debbugs.gnu.org; 4 May 2015 01:44:41 +0000 Original-Received: from localhost ([127.0.0.1]:32878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yp5R2-0004xd-G7 for submit@debbugs.gnu.org; Sun, 03 May 2015 21:44:41 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:12618) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yp5R0-0004xQ-Da for 20491@debbugs.gnu.org; Sun, 03 May 2015 21:44:38 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnEFAGvvdVRFpYts/2dsb2JhbAA3gVOfQYIugQiBdQEBBAFWIwULCw4mEhQYDSSIE6IRjG0DA4M+AwODbQSjY4RY X-IPAS-Result: AnEFAGvvdVRFpYts/2dsb2JhbAA3gVOfQYIugQiBdQEBBAFWIwULCw4mEhQYDSSIE6IRjG0DA4M+AwODbQSjY4RY X-IronPort-AV: E=Sophos;i="5.11,557,1422939600"; d="scan'208";a="118163546" Original-Received: from 69-165-139-108.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.165.139.108]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 03 May 2015 21:44:33 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 37978AE12D; Sun, 3 May 2015 21:44:33 -0400 (EDT) In-Reply-To: <20150503.072916.112599561183374401.devel@pollock-nageoire.net> (Pierre Lorenzon's message of "Sun, 03 May 2015 07:29:16 +0200 (CEST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102431 Archived-At: > error("eieio-oref called on a class!") > eieio-oref(srecode-template-inserter-section-end key) > srecode-compile-inserter("INDENT" "\n" Does the patch below fix this problem? AFAICT, the use of `oref' with a class object was never documented as a supported feature of EIEIO. You're supposed to use oref-default for that. Stefan diff --git a/lisp/cedet/srecode/compile.el b/lisp/cedet/srecode/compile.el index c93a6f7..763c462 100644 --- a/lisp/cedet/srecode/compile.el +++ b/lisp/cedet/srecode/compile.el @@ -523,7 +523,7 @@ to the inserter constructor." (setq classes (append classes (eieio-class-children (car classes)))) ;; Do we have a match? (when (and (not (class-abstract-p (car classes))) - (equal (oref (car classes) key) key)) + (equal (oref-default (car classes) key) key)) ;; Create the new class, and apply state. (setq new (apply (car classes) name props)) (srecode-inserter-apply-state new STATE)