unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 23006@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#23006: 25.0.92; Loading Tramp breaks pcomplete in eshell-mode
Date: Fri, 18 Mar 2016 13:53:48 -0400	[thread overview]
Message-ID: <jwv60wj7ka0.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <8760wj3eks.fsf@gmx.de> (Michael Albinus's message of "Fri, 18 Mar 2016 18:01:39 +0100")

> However, before we start with such radical changes, why do you oppose
> to use non-essential in pcomplete? According to my tests, this solves
> the problem.

non-essential means that what we're doing is a skippable/secondary (aka
non-essential) side-effect of the main operation.  When the user hits
TAB, performing completion is not a skippable side-effect of some other
main operation.  It *is* the main operation.

When the user types "cd /ssh:myhost:src/ema TAB" she *wants* Tramp to
prompt her for a password to then give her the valid completions.

It'd be correct for company-mode to bind non-essential around the code
which computes the completion data in response to the user's normal
editing of the buffer (in order to decide whether the
auto-popup a completion menu), because the completion is not the main
operation.

Similarly it's correct for icomplete to bind non-essential while
computing the completion list, since it's done "in the background" in
response to other editing commands and shouldn't get in the way of those
editing commands.


        Stefan





  reply	other threads:[~2016-03-18 17:53 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14  2:01 bug#23006: 25.0.92; Loading Tramp breaks pcomplete in eshell-mode Dmitry Gutov
2016-03-14  2:22 ` Stefan Monnier
2016-03-14  7:34 ` Michael Albinus
2016-03-15  3:31   ` Stefan Monnier
2016-03-15  8:43     ` Michael Albinus
2016-03-15 11:09       ` Dmitry Gutov
2016-03-17  0:42       ` Stefan Monnier
2016-03-17 19:43         ` Michael Albinus
2016-03-17 19:44           ` Dmitry Gutov
2016-03-17 19:54             ` Michael Albinus
2016-03-17 22:55               ` Dmitry Gutov
2016-03-18  8:27                 ` Michael Albinus
2016-03-18 16:13                   ` Stefan Monnier
2016-03-18 17:01                     ` Michael Albinus
2016-03-18 17:53                       ` Stefan Monnier [this message]
2016-03-18 20:21                         ` Michael Albinus
2016-03-18 22:41                           ` Stefan Monnier
2016-03-19  8:28                             ` Michael Albinus
2016-03-19 12:35                               ` Stefan Monnier
2016-03-19 15:28                                 ` Michael Albinus
2016-03-19 20:04                                   ` Stefan Monnier
2016-03-20 15:08                                     ` Michael Albinus
2016-03-20 15:23                                       ` Stefan Monnier
2016-03-20 15:46                                         ` Michael Albinus
2016-03-20 16:10                                           ` Stefan Monnier
2016-03-20 20:40                                             ` Michael Albinus
2016-03-20 22:17                                               ` Stefan Monnier
2016-03-20 22:28                                                 ` Dmitry Gutov
2016-03-21 15:57                                                 ` Michael Albinus
2016-03-20 15:38                                       ` Drew Adams
2016-03-20 15:54                                         ` Michael Albinus
2016-03-20 15:59                                           ` Dmitry Gutov
2016-03-20 20:31                                             ` Michael Albinus
2016-03-20 20:44                                               ` Dmitry Gutov
2016-03-20 20:53                                                 ` Michael Albinus
2016-03-20 21:05                                                   ` Dmitry Gutov
2016-03-20 22:19                                                     ` Stefan Monnier
2016-03-21 15:49                                                       ` Michael Albinus
2016-03-21 19:26                                                         ` Stefan Monnier
2016-03-22  9:27                                                           ` Michael Albinus
2016-03-22 12:02                                                             ` Stefan Monnier
2016-03-22 12:05                                                               ` Michael Albinus
2016-03-22 13:19                                                                 ` Stefan Monnier
2016-03-21 15:46                                                     ` Michael Albinus
2016-03-21 15:49                                                       ` Dmitry Gutov
2016-03-21 16:03                                                         ` Michael Albinus
2016-03-21 16:13                                                           ` Dmitry Gutov
2016-03-21 16:25                                                             ` Michael Albinus
2016-03-21 16:45                                                               ` Dmitry Gutov
2016-03-21 16:55                                                                 ` Michael Albinus
2016-03-21 18:10                                                                   ` Dmitry Gutov
2016-03-21 18:36                                                                     ` Michael Albinus
2016-03-21 21:26                                                                       ` Dmitry Gutov
2016-03-22  9:47                                                                         ` Michael Albinus
2016-03-22 12:05                                                                           ` Stefan Monnier
2016-03-22 12:20                                                                             ` Michael Albinus
2016-03-22 13:37                                                                               ` Stefan Monnier
2016-03-22 13:50                                                                                 ` Michael Albinus
2016-03-22 14:01                                                                                   ` Stefan Monnier
2016-03-24  1:00                                                                           ` Dmitry Gutov
2016-03-21 19:23                                                                   ` Stefan Monnier
2016-03-22  9:25                                                                     ` Michael Albinus
2016-03-22 12:02                                                                       ` Stefan Monnier
2016-03-22 12:08                                                                         ` Michael Albinus
2016-03-22 13:18                                                                           ` Stefan Monnier
2016-03-22 13:35                                                                             ` Michael Albinus
2016-03-22 13:38                                                                               ` Stefan Monnier
2016-03-22 13:50                                                                                 ` Michael Albinus
2016-03-24  0:54                                                                               ` Dmitry Gutov
2016-03-24 13:15                                                                                 ` Stefan Monnier
2016-03-24 13:54                                                                                   ` Dmitry Gutov
2016-03-24 15:56                                                                                     ` Stefan Monnier
2016-03-20 16:38                                           ` Drew Adams
2016-03-20 19:48                                             ` Drew Adams
2016-03-20 20:42                                               ` Michael Albinus
2016-03-18 22:51                         ` Dmitry Gutov
2016-03-17  0:50   ` Stefan Monnier
2016-03-17 19:49     ` Michael Albinus
2016-03-18 16:06       ` Stefan Monnier
2017-03-09 18:52 ` Michael Albinus
2017-03-15 12:42 ` Michael Albinus
2017-03-17 11:30   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv60wj7ka0.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=23006@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).