From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 23079@debbugs.gnu.org, jonas@bernoul.li
Subject: bug#23079: 25.0.92; Movement commands leave cursor in invisible line
Date: Tue, 22 Mar 2016 21:59:38 -0400 [thread overview]
Message-ID: <jwv60wevuze.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87zitqihlz.fsf@web.de> (Michael Heerdegen's message of "Tue, 22 Mar 2016 17:48:24 +0100")
> (let ((inhibit-read-only t)
> (deactivate-mark nil)
> (selection (magit-region-sections)))
> (mapc #'delete-overlay magit-section-highlight-overlays)
> (setq magit-section-unhighlight-sections
> magit-section-highlighted-sections
> magit-section-highlighted-sections nil)
> (unless (eq section magit-root-section)
> (run-hook-with-args-until-success
> 'magit-section-highlight-hook section selection))
> (--each magit-section-unhighlight-sections
> (run-hook-with-args-until-success
> 'magit-section-unhighlight-hook it selection))
> (restore-buffer-modified-p nil)
Hmm... what kind of buffer modifications might happen in here?
I think this might be the problem: point-adjustment is only applied after
"movement commands" and is disabled if the buffer was modified during
the course of the command (including post-command-hook).
[ This is mostly due to the simplistic way we keep track of the
"previous state", which we can't trust if the buffer was modified. ]
> This function doesn't move point, but it somehow interferes with point
> adjustment in another way.
It's difficult to adjust point without risking adverse effects in corner
cases (typically problems like "repeated C-n gets stuck" or "forward-foo
moves backward"), so point-adjustment is conservative to try and make
sure it's only done when we're sure it's "safe".
Stefan
next prev parent reply other threads:[~2016-03-23 1:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 20:19 bug#23079: 25.0.92; Movement commands leave cursor in invisible line Michael Heerdegen
2016-03-21 20:26 ` Michael Heerdegen
2016-03-21 21:11 ` Stefan Monnier
2016-03-21 22:29 ` Michael Heerdegen
2016-03-22 1:27 ` Stefan Monnier
2016-03-22 16:02 ` Michael Heerdegen
2016-03-22 16:16 ` Stefan Monnier
2016-03-22 16:48 ` Michael Heerdegen
2016-03-23 1:59 ` Stefan Monnier [this message]
2016-03-23 3:41 ` Eli Zaretskii
2016-03-23 11:23 ` Stefan Monnier
2016-03-23 15:12 ` Michael Heerdegen
2016-03-24 2:07 ` Michael Heerdegen
2016-03-24 21:32 ` Michael Heerdegen
2016-03-24 22:01 ` Stefan Monnier
2016-03-25 11:42 ` Jonas Bernoulli
2016-03-25 13:53 ` Eli Zaretskii
2016-03-26 10:21 ` Jonas Bernoulli
2016-03-21 22:54 ` Michael Heerdegen
2020-08-15 4:22 ` Stefan Kangas
2020-10-01 12:26 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv60wevuze.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=23079@debbugs.gnu.org \
--cc=jonas@bernoul.li \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).