From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Olaf Rogalsky <olaf.rogalsky@t-online.de>, 29104@debbugs.gnu.org
Subject: bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings
Date: Sat, 18 Nov 2017 09:43:30 -0500 [thread overview]
Message-ID: <jwv60a7vedm.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <83y3n3gbgn.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Nov 2017 11:52:56 +0200")
>> This patch (#29104) addresses (2). It does not implement a new feature,
>> but tries to make a bugfix to keyboard.c:read_key_sequence. This
>> function is a 900 lines nightmare of spaggheti code, full of global
>> state and goto's. At least it is somehow documented.
Oh, yes, the number of lines has fluctuated a bit, but it's been
a nightmare ever since I first saw it. I'm impressed you found the
stamina to dig into it.
> Stefan, any comments? I'm thinking of installing this on master.
I'll take a look at it later this week-end (it will take some time for
me to re-understand the code ;-)
Stefan
prev parent reply other threads:[~2017-11-18 14:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 13:45 bug#29104: [PATCH]: xterm-mouse-mode clicks in the modeline dont use the keymap properties of the modeline strings Olaf Rogalsky
2017-11-06 23:47 ` Olaf Rogalsky
2017-11-11 9:44 ` Eli Zaretskii
2017-11-13 11:33 ` bug#29104: AW: " olaf.rogalsky
2017-11-13 13:57 ` olaf.rogalsky
2017-11-19 4:24 ` Stefan Monnier
2017-11-19 15:50 ` Eli Zaretskii
2017-11-20 13:26 ` Stefan Monnier
2017-11-20 17:15 ` Eli Zaretskii
2017-11-20 18:06 ` Stefan Monnier
2017-11-19 21:14 ` Olaf Rogalsky
2017-11-18 9:52 ` Eli Zaretskii
2017-11-18 14:43 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv60a7vedm.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=29104@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=olaf.rogalsky@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).