From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#29414: 24.5; failure to configure a particular Ocaml indentation parameter (via SMIE) Date: Thu, 23 Nov 2017 14:26:57 -0500 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1511465257 2852 195.159.176.226 (23 Nov 2017 19:27:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 23 Nov 2017 19:27:37 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 29414@debbugs.gnu.org, monnier@IRO.UMontreal.CA To: Matej =?UTF-8?Q?Ko=C5=A1=C3=ADk?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 23 20:27:33 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHx9j-0008WJ-GP for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 Nov 2017 20:27:27 +0100 Original-Received: from localhost ([::1]:45815 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHx9q-0003xe-Qb for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 Nov 2017 14:27:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHx8R-0002Ud-QF for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2017 14:26:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHx8N-0004Sj-33 for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2017 14:26:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45465) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eHx8M-0004Ql-Ug for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2017 14:26:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eHx8M-00054D-IV for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2017 14:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Nov 2017 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29414 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29414-submit@debbugs.gnu.org id=B29414.151146511719423 (code B ref 29414); Thu, 23 Nov 2017 19:26:02 +0000 Original-Received: (at 29414) by debbugs.gnu.org; 23 Nov 2017 19:25:17 +0000 Original-Received: from localhost ([127.0.0.1]:54146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHx7c-000538-Km for submit@debbugs.gnu.org; Thu, 23 Nov 2017 14:25:16 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:43303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHx7Z-00052s-L6; Thu, 23 Nov 2017 14:25:14 -0500 Original-Received: from lechazo.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id vANJPA3c005716; Thu, 23 Nov 2017 14:25:11 -0500 Original-Received: by lechazo.home (Postfix, from userid 20848) id 10653602DF; Thu, 23 Nov 2017 14:26:58 -0500 (EST) In-Reply-To: ("Matej =?UTF-8?Q?Ko=C5=A1=C3=ADk?="'s message of "Thu, 23 Nov 2017 16:59:20 +0100") X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 3 Rules triggered NOFROM_SGMAIL=0.2, EDT_SA_DN_PASS=0, RV6165=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6165> : inlines <6185> : streams <1771128> : uri <2538927> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140270 Archived-At: forcemerge 24848 29414 thanks > - I run the following command: > > M-: (print smie-config) > > I see > > ((tuareg-mode (4 :before "|-or" nil))) > ((tuareg-mode (4 :before "|-or" nil))) > > I have no idea whether this an expected or unexpected value. :-/ Yes, it's expected because M-: already prints the result of the evaluation, and `print` returns its argument. IOW better just use M-: smie-config RET > - Now my ~/.emacs file looks like this: [...] > '(smie-config (quote ((tuareg-mode (4 :before "|-or" nil)))))) Looks good. > - I press TAB. > What I see is that the whole line is shifted to the right by 2 columns. Which is what happens by default, so it shows that the setting didn't take effect. I tracked this down and this happens to be a known bug which was recently fixed in smie.el. More specifically, it should be fixed in the current Emacs-26 pretest. I reproduced the corresponding patch below, Stefan commit a58d0c590a777be98e58cd8c92ee1381e07e9b2d Author: Noam Postavsky Date: Wed Aug 30 19:31:48 2017 -0400 Fix loading of smie-config rules (Bug#24848) * lisp/emacs-lisp/smie.el (smie-config--setter): Use `set-default' instead of `setq-default'. (smie-config): Use `custom-initialize-set' instead of `custom-initialize-default' as the :initialize argument. diff --git a/lisp/emacs-lisp/smie.el b/lisp/emacs-lisp/smie.el index 87c4782e21..da1e12b140 100644 --- a/lisp/emacs-lisp/smie.el +++ b/lisp/emacs-lisp/smie.el @@ -1956,7 +1956,7 @@ smie-config--mode-hook (defvar smie-config--modefuns nil) (defun smie-config--setter (var value) - (setq-default var value) + (set-default var value) (let ((old-modefuns smie-config--modefuns)) (setq smie-config--modefuns nil) (pcase-dolist (`(,mode . ,rules) value) @@ -1982,7 +1982,7 @@ smie-config ;; FIXME improve value-type. :type '(choice (const nil) (alist :key-type symbol)) - :initialize 'custom-initialize-default + :initialize 'custom-initialize-set :set #'smie-config--setter) (defun smie-config-local (rules)