From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#33749: 26.1; input-decode-map to empty vector should preserve echo area Date: Tue, 25 Dec 2018 15:07:50 -0500 Message-ID: References: <835zvh8k7x.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1545768367 3173 195.159.176.226 (25 Dec 2018 20:06:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Dec 2018 20:06:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: yurivkhan@gmail.com, 33749@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 25 21:06:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbsxm-0000kn-Ua for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Dec 2018 21:06:03 +0100 Original-Received: from localhost ([127.0.0.1]:42725 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbszt-00044m-OD for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Dec 2018 15:08:13 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39313) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbszj-000438-0b for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 15:08:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gbszi-0001Do-CY for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 15:08:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49442) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gbszi-0001De-9D for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 15:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gbszi-0001T3-2K for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 15:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Dec 2018 20:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33749 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33749-submit@debbugs.gnu.org id=B33749.15457684765629 (code B ref 33749); Tue, 25 Dec 2018 20:08:02 +0000 Original-Received: (at 33749) by debbugs.gnu.org; 25 Dec 2018 20:07:56 +0000 Original-Received: from localhost ([127.0.0.1]:36449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbszc-0001Sj-34 for submit@debbugs.gnu.org; Tue, 25 Dec 2018 15:07:56 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:45812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbsza-0001SZ-0s for 33749@debbugs.gnu.org; Tue, 25 Dec 2018 15:07:54 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id wBPK7phS008188; Tue, 25 Dec 2018 15:07:51 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id CCDD8AE1EF; Tue, 25 Dec 2018 15:07:50 -0500 (EST) In-Reply-To: <835zvh8k7x.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 Dec 2018 21:44:34 +0200") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6446=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6446> : inlines <6990> : streams <1808180> : uri <2769936> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153838 Archived-At: >> I think The Right Thing to do is likely to move this code to >> read_key_sequence, more specifically, move it to the point where we >> *know* we really do have an event. >> IOW, I think the patch below might be a better option (where we test >> `indec.start > 0` to make sure some *decoded* event was read). > Where in that patch is the variable that I asked for, which would > trigger this special behavior? Nowhere ;-) Mostly because I don't know where we could set this variable (other than globally). If you want me to add a global var to control whether we use the old or the new behavior, I'm fine with that. Note also that the current patch is likely not quite right yet anyway: I mostly posted it for discussion. E.g. I think where I put it currently, it fails to be run for single-key commands. Stefan