From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group Date: Wed, 02 Jun 2021 09:25:18 -0400 Message-ID: References: <3208B35C4FFE47FFBD0A7029AB2DBB8C@us.oracle.com> <87wnrc7o3p.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12795"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 11301@debbugs.gnu.org, Drew Adams To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 02 15:37:53 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loR4C-00032S-Q2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Jun 2021 15:37:52 +0200 Original-Received: from localhost ([::1]:44720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loR4B-00019r-RV for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Jun 2021 09:37:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loQsk-0007Y7-48 for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 09:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55941) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loQsj-0002a9-Qu for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 09:26:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1loQsj-0000tR-MS for bug-gnu-emacs@gnu.org; Wed, 02 Jun 2021 09:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Jun 2021 13:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11301 X-GNU-PR-Package: emacs Original-Received: via spool by 11301-submit@debbugs.gnu.org id=B11301.16226403283359 (code B ref 11301); Wed, 02 Jun 2021 13:26:01 +0000 Original-Received: (at 11301) by debbugs.gnu.org; 2 Jun 2021 13:25:28 +0000 Original-Received: from localhost ([127.0.0.1]:39250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loQsC-0000s7-9p for submit@debbugs.gnu.org; Wed, 02 Jun 2021 09:25:28 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:32424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loQsA-0000rt-BD for 11301@debbugs.gnu.org; Wed, 02 Jun 2021 09:25:26 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EF924806A5; Wed, 2 Jun 2021 09:25:20 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7E55A80497; Wed, 2 Jun 2021 09:25:19 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1622640319; bh=/y37IhGWeMALsDhVfS08rOFMmar9IIxv06ZnfrVuHw0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=D23SfQ6G8idpItBUy4LaVbH+X6la45H8nefKnr1xTD5cLIQIwT61tBkwXr0FWv/YN lOfqZ3oDRRpVcxSlaFyHB8rtzcnCvULeZ4nRHM6iMcL9EQ8yW3q1ZLvgwANWxyHzN2 zY83Cn6Fxqb7oUSMoaIxat0N22ofbJw4A+k+jNGOhs6VINE855R7TbK3sLrcVSjTeY bLuh2X7lGS6U5Je/Xky+8EGX3NXmQWna5XLU7QO97gIzHkM/V5Yn2mqdmcbEBAXEI1 Mx/SHRnMXLW/yvls50SwqcDIs1KsI7LV4wpI89a1lnO7G4XNz36rIrxqLaYp+C2tF4 ejqTklP12ocLA== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 33A1812023C; Wed, 2 Jun 2021 09:25:19 -0400 (EDT) In-Reply-To: <87wnrc7o3p.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 02 Jun 2021 08:54:50 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207866 Archived-At: > I've tried following the logic and history of the :group keyword in > easy-mmode.el, and I'm not sure how that's supposed to work any more. > > `define-minor-mode' used to document taking a :group keyword, but that's > been removed in: Yes, it tried to be clever and guess the `:group` arg when none was provided, but that guess was worse than the defaulting used by `defcustom`. Since the `:group` was only used for the `defcustom`, I just removed this special handling. It doesn't mean it doesn't work any more, but now it's just another one of the keyword args that are simply passed as-is to `defcustom`. So this has no direct impact on whether or not `define-minor-mode` should register the mode for use in `customize-mode` (which sounds like a good idea). Stefan