bug#12369: 24.2.50; cl-loop: variable not left unused

bug#12369: 24.2.50; cl-loop: variable not left unused

[Christopher Schmidt]

severity: minor

    ;; -*- lexical-binding: t -*-

    (require 'cl-lib)
    (cl-loop for (rms . emacs) in nil)

Byte compile this piece of code.

    Warning: Unused lexical variable `rms'

Attempting to fix this warning by renaming rms to _rms results in
another warning.

    Warning: variable `_rms' not left unused

GNU Emacs 24.2.50.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10) of
2012-09-06.

        Christopher

bug#12369: 24.2.50; cl-loop: variable not left unused

[Stefan Monnier]

>     ;; -*- lexical-binding: t -*-
>     (require 'cl-lib)
>     (cl-loop for (rms . emacs) in nil)
> Byte compile this piece of code.
>     Warning: Unused lexical variable `rms'

Yes, first bug: `emacs' is not listed as unused.

> Attempting to fix this warning by renaming rms to _rms results in
> another warning.
>     Warning: variable `_rms' not left unused

Yup, second bug.

This is all due to the code generated by cl-loop which was optimized to
use `set' in the loop instead of `let'.  This made sense for dynamically
scoped code where `let' is a bit slower, but for lexically-scoped code,
it's the exact opposite, so we should change the generated code from:

   (identity
    (catch '--cl-block-nil--
      (let* ((--cl-var-- nil)
             (emacs nil) (rms nil))
        (while (consp --cl-var--)
          (setq emacs (car --cl-var--) rms (pop emacs))
          (setq --cl-var-- (cdr --cl-var--)))
        nil)))
to
   (identity
    (catch '--cl-block-nil--
      (let* ((--cl-var-- nil))
        (while (consp --cl-var--)
          (let* ((tmp (car --cl-var--))
                 (emacs (car tmp))
                 (rms (cdr tmp)))
            (setq --cl-var-- (cdr --cl-var--))))
        nil)))


-- Stefan

bug#12369: 24.2.50; cl-loop: variable not left unused

[Lars Ingebrigtsen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>     ;; -*- lexical-binding: t -*-
>>     (require 'cl-lib)
>>     (cl-loop for (rms . emacs) in nil)
>> Byte compile this piece of code.
>>     Warning: Unused lexical variable `rms'
>
> Yes, first bug: `emacs' is not listed as unused.

This problem is still present in Emacs 28.

>> Attempting to fix this warning by renaming rms to _rms results in
>> another warning.
>>     Warning: variable `_rms' not left unused
>
> Yup, second bug.

This one is fixed, though.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#12369: 24.2.50; cl-loop: variable not left unused

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>>>     ;; -*- lexical-binding: t -*-
>>>     (require 'cl-lib)
>>>     (cl-loop for (rms . emacs) in nil)
>>> Byte compile this piece of code.
>>>     Warning: Unused lexical variable `rms'
>> Yes, first bug: `emacs' is not listed as unused.
> This problem is still present in Emacs 28.

Indeed, because it *is* used internally by the code expanded from the
destructuring-bind.

>>> Attempting to fix this warning by renaming rms to _rms results in
>>> another warning.
>>>     Warning: variable `_rms' not left unused
>> Yup, second bug.
> This one is fixed, though.

Hmm... I wonder what caused this change.


        Stefan