From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#49104: [PATCH] 28.0.50; Handle remapped commands for M-TAB in `flyspell-prog-mode' Date: Sun, 27 Jun 2021 15:07:19 -0400 Message-ID: References: <83a6nmxu95.fsf@gnu.org> <83pmwivyf7.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2985"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , 49104@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 27 21:08:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lxa8W-0000Wx-H1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Jun 2021 21:08:08 +0200 Original-Received: from localhost ([::1]:41008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxa8V-0001zj-JY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Jun 2021 15:08:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxa8Q-0001zb-Qt for bug-gnu-emacs@gnu.org; Sun, 27 Jun 2021 15:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38857) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lxa8Q-0001Tl-K2 for bug-gnu-emacs@gnu.org; Sun, 27 Jun 2021 15:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lxa8Q-0000Nf-C9 for bug-gnu-emacs@gnu.org; Sun, 27 Jun 2021 15:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Jun 2021 19:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49104-submit@debbugs.gnu.org id=B49104.16248208511423 (code B ref 49104); Sun, 27 Jun 2021 19:08:02 +0000 Original-Received: (at 49104) by debbugs.gnu.org; 27 Jun 2021 19:07:31 +0000 Original-Received: from localhost ([127.0.0.1]:50403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxa7v-0000Mt-Cx for submit@debbugs.gnu.org; Sun, 27 Jun 2021 15:07:31 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxa7r-0000Me-LY for 49104@debbugs.gnu.org; Sun, 27 Jun 2021 15:07:30 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3D6F8440B73; Sun, 27 Jun 2021 15:07:22 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2681D440030; Sun, 27 Jun 2021 15:07:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1624820841; bh=wq00/55Y7uURs7nZnAfX21KmPu24cr2QMK8HW2vge5Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XZJNZxsOcaEnoM//Mvr2yTg1CFQ/2MKundIV1NgagUcA/Rt8cH22BEoV7j/6084Vj L9sCTp61f/RWwc4UCbJaRDc0hRtVqD1kF4vqJNS7pXxM1jIzjfhIedQ7e3Tscnv7qe /mEBsbOW4E2wXR1+XAzL1VB2ulZ5bqr0btMQ3Qw/iOZ2+0FDCVRh54mBh3XJXS/Un1 RSuPzDVERgfp5OKjeE/ABN2FWRQ53UUj4pWhoNHXu/2MxIGpH1j2vPAOkDfN8CeD7w j+7kDoWUPdIJ3gqHHpVaUuiHSldGZNf1+8/WGkQ64zI62f+Fpvr8Hxpz0+Q7+QTBAq OAwQP3jVgL0sQ== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A0FF5120B51; Sun, 27 Jun 2021 15:07:20 -0400 (EDT) In-Reply-To: (Jim Porter's message of "Sat, 19 Jun 2021 10:31:38 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209036 Archived-At: I pushed a slightly cleaner version of my patch, Stefan Jim Porter [2021-06-19 10:31:38] wrote: > On Sat, Jun 19, 2021 at 10:24 AM Stefan Monnier > wrote: >> In that case, `key-binding` might be a good replacement. >> I see that using `key-binding` could find flyspell's own binding, tho, so we >> should probably use the (first) patch below instead. >> >> Tho I also wonder why we do the lookup when flyspell is enabled instead >> of doing directly in flyspell-auto-correct-word as in the second >> patch below. > > Indeed, while I was looking into this some more, I saw that > `flyspell-auto-correct-word' is bound to both `M-TAB' and `C-.' in > `flyspell-mode-map'. Your second patch should properly delegate to the > right command for either binding, which would be very nice. The > original code (and my patch) always act as though you typed `M-TAB' > when delegating, which isn't quite right.