unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#51517: GNU ELPA - SVG badge broken
@ 2021-10-30 17:18 tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2021-10-31 15:30 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 5+ messages in thread
From: tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-10-30 17:18 UTC (permalink / raw)
  To: 51517

Recent built packages have broken badges.

The badge from https://elpa.gnu.org/packages/vertico.html is not broken.
(vertico 0.14, updated 2021-Aug-11)

The badge from https://elpa.gnu.org/packages/consult.html is broken.
(consult 0.12, updated 2021-Oct-11)

I read the broken badge (https://elpa.gnu.org/packages/consult.svg) and 
elpa-admin.el. I suspect `elpaa--string-width` returns 0.


--
tsuucat






^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#51517: GNU ELPA - SVG badge broken
  2021-10-30 17:18 bug#51517: GNU ELPA - SVG badge broken tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-10-31 15:30 ` Lars Ingebrigtsen
  2021-10-31 21:41   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2021-10-31 15:30 UTC (permalink / raw)
  To: tsuucat; +Cc: 51517, Stefan Monnier

tsuucat <tsuucat@icloud.com> writes:

> The badge from https://elpa.gnu.org/packages/vertico.html is not broken.
> (vertico 0.14, updated 2021-Aug-11)
>
> The badge from https://elpa.gnu.org/packages/consult.html is broken.
> (consult 0.12, updated 2021-Oct-11)
>
> I read the broken badge (https://elpa.gnu.org/packages/consult.svg) and 
> elpa-admin.el. I suspect `elpaa--string-width` returns 0.

Perhaps Stefan has some insight here; added to the CCs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#51517: GNU ELPA - SVG badge broken
  2021-10-31 15:30 ` Lars Ingebrigtsen
@ 2021-10-31 21:41   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2021-10-31 22:09     ` Daniel Mendler
  0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-10-31 21:41 UTC (permalink / raw)
  To: Daniel Mendler; +Cc: Lars Ingebrigtsen, 51517, tsuucat

Hi Daniel,

Lars Ingebrigtsen [2021-10-31 16:30:04] wrote:
> tsuucat <tsuucat@icloud.com> writes:
>> The badge from https://elpa.gnu.org/packages/vertico.html is not broken.
>> (vertico 0.14, updated 2021-Aug-11)
>> The badge from https://elpa.gnu.org/packages/consult.html is broken.
>> (consult 0.12, updated 2021-Oct-11)
>> I read the broken badge (https://elpa.gnu.org/packages/consult.svg) and 
>> elpa-admin.el. I suspect `elpaa--string-width` returns 0.
> Perhaps Stefan has some insight here; added to the CCs.

I haven't had a chance to look at it yet, but this code is from Daniel,
so maybe he has an idea of what's going on?


        Stefan






^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#51517: GNU ELPA - SVG badge broken
  2021-10-31 21:41   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-10-31 22:09     ` Daniel Mendler
  2021-11-24 23:04       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Mendler @ 2021-10-31 22:09 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Lars Ingebrigtsen, 51517, tsuucat

Hi Stefan!

> Lars Ingebrigtsen [2021-10-31 16:30:04] wrote:
>> tsuucat <tsuucat@icloud.com> writes:
>>> The badge from https://elpa.gnu.org/packages/vertico.html is not broken.
>>> (vertico 0.14, updated 2021-Aug-11)
>>> The badge from https://elpa.gnu.org/packages/consult.html is broken.
>>> (consult 0.12, updated 2021-Oct-11)
>>> I read the broken badge (https://elpa.gnu.org/packages/consult.svg) and 
>>> elpa-admin.el. I suspect `elpaa--string-width` returns 0.
>> Perhaps Stefan has some insight here; added to the CCs.
> 
> I haven't had a chance to look at it yet, but this code is from Daniel,
> so maybe he has an idea of what's going on?

The code uses imagemagick "convert" to determine the width in pixels,
which is font dependent. So I assume something broke on the system -
update of the system package, or maybe imagemagick or the font was
removed. This part of the code is not exactly robust unfortunately - if
I recall correctly, you even had to install a few missing packages to
get this to work after I implemented the badges.

Daniel





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#51517: GNU ELPA - SVG badge broken
  2021-10-31 22:09     ` Daniel Mendler
@ 2021-11-24 23:04       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-11-24 23:04 UTC (permalink / raw)
  To: Daniel Mendler; +Cc: Lars Ingebrigtsen, 51517-done, tsuucat

> The code uses imagemagick "convert" to determine the width in pixels,
> which is font dependent. So I assume something broke on the system -
> update of the system package, or maybe imagemagick or the font was
> removed.

Somehow the font was removed, indeed.  So your crystal ball was right on
the money; sadly, I was too dense to figure out what to do with that info.


        Stefan






^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-24 23:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-30 17:18 bug#51517: GNU ELPA - SVG badge broken tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-31 15:30 ` Lars Ingebrigtsen
2021-10-31 21:41   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-31 22:09     ` Daniel Mendler
2021-11-24 23:04       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).