From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#45767: bug#45768: icomplete-mode does not provide in region completion for dabbrev-completion Date: Mon, 09 May 2022 17:23:00 -0400 Message-ID: References: <255598638.117929.1610282275124@office.mailbox.org> <87k0ayh499.fsf@gnus.org> <86h75zkid4.fsf@mail.linkov.net> <871qx3ca18.fsf@gnus.org> <8635hi1rcm.fsf@mail.linkov.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18326"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 45768@debbugs.gnu.org, Lars Ingebrigtsen , simon254@mailbox.org, 45767@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 09 23:25:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1noAsa-0004XZ-V8 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 23:25:21 +0200 Original-Received: from localhost ([::1]:49128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1noAsZ-0002zI-T4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 17:25:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1noArK-000289-RN for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 17:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1noArK-0000Rs-IW for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 17:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1noArK-0000Q3-B8 for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 17:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2022 21:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45767 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 45767-submit@debbugs.gnu.org id=B45767.16521313911541 (code B ref 45767); Mon, 09 May 2022 21:24:02 +0000 Original-Received: (at 45767) by debbugs.gnu.org; 9 May 2022 21:23:11 +0000 Original-Received: from localhost ([127.0.0.1]:59613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noAqU-0000Om-PB for submit@debbugs.gnu.org; Mon, 09 May 2022 17:23:10 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1noAqT-0000OU-3q; Mon, 09 May 2022 17:23:09 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 23E541001CB; Mon, 9 May 2022 17:23:03 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A0C52100118; Mon, 9 May 2022 17:23:01 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1652131381; bh=MlHDlnDCMvPMODrJlT1tX+aWOkRWo7VBb9kPWBND4+8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eXuRoCVKZUG63UUlIpTMwctdAr1uovYhhVk1/K/xewHUGizFGM5lifqLOEuefhcwD fquBA7UpaIwPgl1iodJ2fUjgVsD3f5LLF+O9Bmy4Z9QpEKhJMbvEwmkucBAgBfEEE9 wy8Wp0gE5Yt4RNz4sYIikGTr+CLTOUgHRblHw/PZn0VliyigI4Rd0cA4XHVwUPgIdD 8frxvBcDTt3E3h+RVUTD7uPgxD56ezi7RSqTUrbT4wF1AakpdxYyRSz3VnMROxY3fM tJXIBUT7fD6oQLbcsWbkfYJ4/dHBDRb3wSjheBb1mKXbxoCZwfNsS0DA6kzi5shFDa WdX5NUsFsWSiA== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8FC77120235; Mon, 9 May 2022 17:23:01 -0400 (EDT) In-Reply-To: <8635hi1rcm.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 09 May 2022 21:41:13 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231784 Archived-At: Juri Linkov [2022-05-09 21:41:13] wrote: >>> Could you explain where do you see that icomplete-mode is not invoked? >>> Should it enable icomplete keys in the buffer? Or there is some >>> visual difference before the fixes and after? >> Stefan fixed this now, I think? > How do you see that it's fixed? Try the recipe given in the bug report. You should see now that after M-C-/ the possible completions get listed (in icomplete-mode style) on the same line (via an overlay). The `icomplete-in-buffer` functionality is very rough around the edges. I only implemented it as a kind of "proof of concept". I think things like `corfu-mode` work much better (because they don't displace existing text in the buffer, they are just drawn on top of it). [ To be honest, in my memory (from when I wrote the code), the list was shown in the echo area rather than "inline". ] Stefan