From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58396: 29.0.50; Optimization failure for add-to-list Date: Sat, 30 Sep 2023 09:56:09 -0400 Message-ID: References: <87o7uknkyx.fsf@gnus.org> <87fsfwnkl4.fsf@gnus.org> <87a663kxtz.fsf@gnus.org> <87czaygqqp.fsf@gnus.org> <87fsfte2hf.fsf@gnus.org> <87o7hod6dk.fsf@sappc2.fritz.box> <87v8bwip2h.fsf@sappc2.fritz.box> <87ttrcaqrm.fsf@sappc2.fritz.box> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="890"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: German Pacenza , 58396@debbugs.gnu.org, Lars Ingebrigtsen To: Jens Schmidt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 30 15:57:02 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qmaSr-000ASf-57 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Sep 2023 15:57:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qmaSg-00016c-SW; Sat, 30 Sep 2023 09:56:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmaSe-00016O-NZ for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2023 09:56:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qmaSd-000745-1v for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2023 09:56:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qmaSs-00040i-Ds for bug-gnu-emacs@gnu.org; Sat, 30 Sep 2023 09:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Sep 2023 13:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58396 X-GNU-PR-Package: emacs Original-Received: via spool by 58396-submit@debbugs.gnu.org id=B58396.169608220515407 (code B ref 58396); Sat, 30 Sep 2023 13:57:02 +0000 Original-Received: (at 58396) by debbugs.gnu.org; 30 Sep 2023 13:56:45 +0000 Original-Received: from localhost ([127.0.0.1]:59599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmaSa-00040Q-4C for submit@debbugs.gnu.org; Sat, 30 Sep 2023 09:56:44 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:35945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmaSU-00040H-M4 for 58396@debbugs.gnu.org; Sat, 30 Sep 2023 09:56:42 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 48D034416BA; Sat, 30 Sep 2023 09:56:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1696082171; bh=C5EJDX4nT/kySEe18mRFxBdvQuhNVxuyofv1uTrej4A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=e7oyLuFI0DSSE0RN5fF1l+qA5gCx239/wO4X+kphcl72UXeirgN6sVw4mYpJktOmg e78XcvZiNBylEqG3C3q30ISA4bNgI53gwOqshlTJUTiqNptvRlTd0WE8huT1ZOQBMf XXhkGp2edoUD1sbnc0x0K13JhORfkU+ZzfArB54vNuRgomYSrYqN16fKVwajqBUAxm k84rcluX6hUe1tV7aSd0P/2/DW0mr2RpUr2ZosZdZjhURs3HeDLxRUR7KHvFaUJOkE 5vgOJ4cfe85mtg+QMfj2gERbtLINqcmpQa1aMNAcrjDoFHKd2kmdugDM98coMxKP6b DBgorMaenmymQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 799A8441872; Sat, 30 Sep 2023 09:56:11 -0400 (EDT) Original-Received: from pastel (unknown [216.154.20.132]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3D184120223; Sat, 30 Sep 2023 09:56:11 -0400 (EDT) In-Reply-To: <87ttrcaqrm.fsf@sappc2.fritz.box> (Jens Schmidt's message of "Sat, 30 Sep 2023 12:39:57 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271544 Archived-At: > + (let ((inhibit-message t) ;[1] > + (warning-minimum-log-level :emergency)) > (advice-add 'macroexpand :around macroexpand-advice) > - (macroexpand-all sexp)) > + (condition-case nil ;[3] > + (macroexpand-all sexp) > + (t sexp))) This `t` catches more than errors. Better replace it with `error`. > - (let ((warning-minimum-log-level :emergency)) > + (let ((inhibit-message t) ;[1] > + (macroexp-inhibit-compiler-macros t) ;[2] > + (warning-minimum-log-level :emergency)) > (advice-add 'macroexpand-1 :around macroexpand-advice) > - (macroexpand-all sexp elisp--local-macroenv)) > + (condition-case nil ;[3] > + (macroexpand-all sexp elisp--local-macroenv) > + (t sexp))) What kind of errors are we expecting to catch with this `condition-case`? The pre-existing advice is supposed to catch macro expansion errors, and the new let-binding is supposed to catch compiler-macro errors, so it seems to me there aren't any *expected* errors left. If so, better remove this `condition-case` (or replace it with `with-demoted-errors`) since all it has left to do is to hide any real coding error that may come up and that we'd like to be told about. Stefan