From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Mitchell <mitchellahren@gmail.com>, 71644@debbugs.gnu.org
Subject: bug#71644: 30.0.50; Severe slowdown in larger files with markers beginning in emacs 29+
Date: Fri, 21 Jun 2024 17:06:31 -0400 [thread overview]
Message-ID: <jwv5xu210i4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <86y16ylrj9.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Jun 2024 09:48:58 +0300")
> commit 8783700b23e70874c4996908bf02c010ae6f3fe1
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> AuthorDate: Tue Aug 2 10:38:53 2022 -0400
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
> CommitDate: Tue Aug 2 13:06:51 2022 -0400
>
> * src/xdisp.c (redisplay_window): Use BEG rather than hard coding 1
>
> It changed the comparison operator in two places in marker.c.
>
> Curiously, the log message doesn't even mention the change in
> marker.c, which could be a sign that this change was not intended to
> be installed. Stefan, did you intend to install it, and if so, do you
> have any comments about this bug report?
Hmm... can't remember why/how it ended up in the above commit.
Looks like an oversight. But the change should be harmless: the
`eassert` should make sure that the comparison gives the same answer
either way (and AFAICT if/when the new comparison gives a different
answer from the old code, the old code will loop until it segfaults).
> I'm a bit confused by the fact that I don't see the slowdown on my
> machine, but maybe there are other factors at work here that hide
> the regression.
The byte<->char conversion code is affected by many unrelated moving
parts, so it can be difficult to come up with a reproducible recipe.
Stefan
next prev parent reply other threads:[~2024-06-21 21:06 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 5:25 bug#71644: 30.0.50; Severe slowdown in larger files with markers beginning in emacs 29+ Mitchell
2024-06-19 12:56 ` Eli Zaretskii
2024-06-20 13:49 ` Ihor Radchenko
2024-06-20 16:11 ` Eli Zaretskii
2024-06-20 16:24 ` Eli Zaretskii
2024-06-20 18:57 ` Mitchell
2024-06-20 19:04 ` Eli Zaretskii
2024-06-21 2:46 ` Mitchell
2024-06-21 6:19 ` Ihor Radchenko
2024-06-21 20:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-22 5:23 ` Gerd Möllmann
2024-06-22 14:10 ` Ihor Radchenko
2024-06-22 15:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-25 3:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-25 4:00 ` Eli Zaretskii
2024-06-25 9:30 ` Ihor Radchenko
2024-06-25 13:44 ` Eli Zaretskii
2024-06-25 13:50 ` Ihor Radchenko
2024-06-25 13:57 ` Eli Zaretskii
2024-06-25 14:25 ` Ihor Radchenko
2024-06-26 3:53 ` Mitchell
2024-06-26 12:41 ` Eli Zaretskii
2024-06-25 20:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-26 11:41 ` Eli Zaretskii
2024-06-26 12:35 ` Ihor Radchenko
2024-06-26 13:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-26 13:49 ` Ihor Radchenko
2024-06-26 14:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-29 21:27 ` Mitchell
2024-06-25 21:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-21 6:48 ` Eli Zaretskii
2024-06-21 21:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-06-22 6:57 ` Eli Zaretskii
2024-06-22 18:03 ` Mitchell
2024-06-22 18:17 ` Eli Zaretskii
2024-06-24 7:09 ` Mitchell
2024-06-24 12:38 ` Eli Zaretskii
2024-06-25 3:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-22 13:53 ` Ihor Radchenko
2024-06-22 14:12 ` Eli Zaretskii
2024-06-22 14:15 ` Eli Zaretskii
2024-06-22 15:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv5xu210i4.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=71644@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mitchellahren@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).