From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74504: 31.0.50; Wrong source directory in *Help* Date: Fri, 13 Dec 2024 17:51:31 -0500 Message-ID: References: <86v7vvisq7.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3671"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 74504@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 13 23:53:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tMEWz-0000n4-Bt for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Dec 2024 23:53:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMEWY-0000Iu-Ns; Fri, 13 Dec 2024 17:52:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMEVw-00008D-RY for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2024 17:52:11 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tMEVu-0000IN-Og for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2024 17:52:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=1LD4b9VZCZkZmDEsbyJrAy+Q7zE1ZQsSNadOQ4xR6Ug=; b=ALS1ajscWxa0Sqp4N2XRRZ8kOg9z/xBOr4iRPIIFDlwR49TZbNKGPhDMxX1XLHCSjZmKm+Gviw4xpRwqa0oNeX9eFn8zmpVBfXf/oN3qzvkovc9RQkPsgDEO7MqIhHWlM2bLO6d5ChNrldKD1Sna/W+qypIK1n+XwpfBgRCwRAy6JOx/SymVgboXHFXW+E+wuv8zCqqDUwIZPCKc+gp+3mbO0j17TPUDA+/w7xVZLXjcDYfRJAmMdhYyGkeGt5T0Cid+Emp7EgDjIgeT/LOoFSygO8qUXZWoCfzC67qOQbf8Gwdion4JihIVYkuyWq++FSXEd4tlYUpAXkxWpJGilA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tMEVu-0000yd-6K for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2024 17:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Dec 2024 22:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74504 X-GNU-PR-Package: emacs Original-Received: via spool by 74504-submit@debbugs.gnu.org id=B74504.17341303033715 (code B ref 74504); Fri, 13 Dec 2024 22:52:02 +0000 Original-Received: (at 74504) by debbugs.gnu.org; 13 Dec 2024 22:51:43 +0000 Original-Received: from localhost ([127.0.0.1]:44515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMEVa-0000xr-Td for submit@debbugs.gnu.org; Fri, 13 Dec 2024 17:51:43 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMEVW-0000xP-QQ for 74504@debbugs.gnu.org; Fri, 13 Dec 2024 17:51:40 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9102910004A; Fri, 13 Dec 2024 17:51:32 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1734130291; bh=jVIny3FeDOw76HHMYNpX+2pXU3GEHWJ7QTbparAuPeg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=L15zGvb3JWLe8kTFvdH83hZJQ9cb/6wAyCu1BEFO4H22/2fDCIxQKaZqLD1JvWGHt R36OoYxXqAURbSPUPp3pR2k4BOdNwKyWQavGnsGXDF5BguaCO+hGU6Q7+1Z7FswO/U vg9LkzxPyq4I8X7a37bNEfCR1GU6WbuaTSee4tWjBeztLjjl5WMFaNYtQumQKUgkoL Cx2Jd2qsppkWvJwgKs5YlR5276/b+N/zxMVjvtvAxb5IxImu9Y6CDUglyG5ex/pfC7 YrHra1CtxawBVJrT+sMkXKiTTUUclkVGR4HIKtKfGE7WgIdI1/o8G/IPdWq/xqa6oi yaQurj/raByuQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E587A100042; Fri, 13 Dec 2024 17:51:31 -0500 (EST) Original-Received: from alfajor (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B38EF120243; Fri, 13 Dec 2024 17:51:31 -0500 (EST) In-Reply-To: (Eshel Yaron's message of "Sun, 08 Dec 2024 08:35:34 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296996 Archived-At: > I think that the workaround Stefan suggests makes sense. Pushed a slightly tweaked patch to `master`. > It doesn't make the code (and the implicit assumptions about when > a file name is absolute and when it isn't) any clearer though. > Another option may be something like the following, where we > explicitly look only for .el files under load-path: AFAICT the other parts of the code treat specially the C files rather than the ELisp files. Not sure if it matters (e.g. for `.so` Emacs modules?), but I'd rather try and use the same hack here as elsewhere. FWIW, the other place I find this distinction is `find-function-search-for-symbol` where we do: (if (string-match "\\`src/\\(.*\\.\\(c\\|m\\)\\)\\'" library) (find-function-C-source symbol (match-string 1 library) type) And the `src/*.c` strings come from `help-C-file-name`. We should label those strings better in order to know more reliably whether they're supposed to be searched in `load-path` or in `find-function-S-source-directory` or god knows where else. But in the mean time, this specific bug is fixed. Stefan