From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: 1052@emacsbugs.donarmstrong.com, Chong Yidong <cyd@stupidchicken.com>
Subject: bug#1052: segfault when resuming emacsclient -t in an xterm
Date: Tue, 30 Sep 2008 18:06:27 -0400 [thread overview]
Message-ID: <jwv4p3xb9ti.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <200809301818.m8UIIGFf003951@mothra.ics.uci.edu> (Dan Nicolaescu's message of "Tue, 30 Sep 2008 11:18:16 -0700 (PDT)")
>> > The problem is that after the cited change
>> > `xterm-remove-modify-other-keys' calls `terminal-live-p' (it was
>> > previously using `frame-live-p') before calling
>> > `send-string-to-terminal'.
>> >
>> > `terminal-live-p' does not return false when tty->output is NULL --->
>> > KABOOM.
>>
>> Looks like it's just a matter of checking tty->output, then. WDYT?
> Not sure it's a good idea.
> The test for `frame-live-p' was trying to make sure that the frame is OK
> and `send-string-to-terminal' would work.
> Not sure
> 1. why was it replaced with `terminal-live-p'
Because the function receives a `terminal' argument.
> 2. maybe `terminal-live-p' needs to be changed to detect this condition
I think there are 2 problems:
1- xterm-remove-modify-other-keys forgets to pass `terminal'
to `send-string-to-terminal'. Hopefully, I've just fixed it, so that
your recipe should not causes a segfault any more.
2- send-string-to-terminal causes a segfault is called for a terminal
that is suspended. I've made it signal an error.
Stefan
next prev parent reply other threads:[~2008-09-30 22:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 17:06 bug#1052: segfault when resuming emacsclient -t in an xterm Chong Yidong
2008-09-30 18:18 ` Dan Nicolaescu
2008-09-30 22:06 ` Stefan Monnier [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-29 17:46 Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4p3xb9ti.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=1052@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
--cc=dann@ics.uci.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).