From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#6256: 24.0.50; read-event in `repeat' command Date: Mon, 05 Jul 2010 00:45:37 +0200 Message-ID: References: <058F2FC300154C1AB894694655B2A968@us.oracle.com> <90A72397ABF34D84A3ACB3B6DE18F74A@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1278336600 6885 80.91.229.12 (5 Jul 2010 13:30:00 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 5 Jul 2010 13:30:00 +0000 (UTC) Cc: 6256@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 05 15:29:59 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OVlkB-000359-2L for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jul 2010 15:29:55 +0200 Original-Received: from localhost ([127.0.0.1]:33936 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVlkA-0006j8-Bu for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jul 2010 09:29:54 -0400 Original-Received: from [140.186.70.92] (port=33177 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVlk2-0006i7-7E for bug-gnu-emacs@gnu.org; Mon, 05 Jul 2010 09:29:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OVlk0-0001SJ-UI for bug-gnu-emacs@gnu.org; Mon, 05 Jul 2010 09:29:46 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50134) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVlk0-0001SF-RV for bug-gnu-emacs@gnu.org; Mon, 05 Jul 2010 09:29:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OVlYg-0002rB-8p; Mon, 05 Jul 2010 09:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Jul 2010 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6256 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6256-submit@debbugs.gnu.org id=B6256.127833586210973 (code B ref 6256); Mon, 05 Jul 2010 13:18:02 +0000 Original-Received: (at 6256) by debbugs.gnu.org; 5 Jul 2010 13:17:42 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVlYL-0002qw-AU for submit@debbugs.gnu.org; Mon, 05 Jul 2010 09:17:41 -0400 Original-Received: from drizzle.cc.mcgill.ca ([132.206.27.48]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVlYJ-0002qr-Hx for 6256@debbugs.gnu.org; Mon, 05 Jul 2010 09:17:40 -0400 Original-Received: from mailscan3.ncs.mcgill.ca (mailscan3.NCS.McGill.CA [132.216.77.250]) by drizzle.cc.mcgill.ca (8.12.11.20060308/8.12.3) with ESMTP id o65DHY2V023156; Mon, 5 Jul 2010 09:17:34 -0400 Original-Received: from mailscan3.ncs.mcgill.ca (localhost [127.0.0.1]) by localhost (Postfix) with SMTP id 5F53B5E46; Mon, 5 Jul 2010 09:17:34 -0400 (EDT) Original-Received: from alfajor.home (vpn87205.VPN.McGill.CA [132.216.87.205]) by mailscan3.ncs.mcgill.ca (Postfix) with ESMTP id 06FCA5DA0; Mon, 5 Jul 2010 09:17:33 -0400 (EDT) Original-Received: by alfajor.home (Postfix, from userid 20848) id 9F71CBB542; Mon, 5 Jul 2010 00:45:37 +0200 (CEST) In-Reply-To: (Drew Adams's message of "Sat, 3 Jul 2010 14:24:23 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-PMX-Version: 5.4.2.338381, Antispam-Engine: 2.6.0.325393, Antispam-Data: 2010.6.9.160619 X-McGill-WhereFrom: Internal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 05 Jul 2010 09:18:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38237 Archived-At: > That does not happen, however, because of this restrictive `eq' test in the > definition of function `repeat': > (while (eq (read-event) repeat-repeat-char) > (repeat repeat-arg)) > The event read will be something like this, for the wheel action: > (wheel-down (# 2051 (118 . 176) 158455015 nil > 2051 (59 . 40) nil (26 . 2) (2 . 4))) > I would think that we would want to change the test to this, or similar: > (while (let ((evt (read-event))) > (and (equal (event-basic-type evt) (event-basic-type > repeat-repeat-char)) > (equal (event-modifiers evt) (event-modifiers > repeat-repeat-char)))) > (repeat repeat-arg)) > And that seems to work OK. What do you think - is it reasonable to do > that? That sounds right, yes, People, feel free to make such a change, Stefan