From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo <sdl.web@gmail.com>
Cc: 3230@debbugs.gnu.org
Subject: bug#3230: 23.0.93; Make dired-actual-switches safe local variable?
Date: Thu, 24 Feb 2011 09:57:04 -0500 [thread overview]
Message-ID: <jwv4o7t1o9z.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m1aahmvsbf.fsf@gmail.com> (Leo's message of "Thu, 24 Feb 2011 14:51:16 +0800")
> (defun dired-actual-switches-p (switches)
> (and (stringp switches)
> (catch 'exit
> (mapc (lambda (switch)
> (unless (eq (aref switch 0) ?-)
> (throw 'exit nil)))
> (split-string switches nil t))
> t)))
Hmm, what about "-l;reboot" ?
BTW, writing a predicate is the right thing to so, and the predicate
should then go to safe-local-variable. I'd recommend something simple
like
(defun dired-safe-switches-p (switches)
(string-match "\\`[- [[:alnum:]]]+\\'" switches))
Hopefully that one is safe (tho maybe we should check string-length to
avoid attacks playing on overflow). And if it proves too restrictive,
we can make it a bit more permissive once we encounter a particular
example that warrants it.
Stefan
next prev parent reply other threads:[~2011-02-24 14:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 14:20 bug#3230: 23.0.93; Make dired-actual-switches safe local variable? Leo
2011-02-24 2:08 ` Glenn Morris
2011-02-24 4:46 ` Leo
2011-02-24 6:51 ` Leo
2011-02-24 14:57 ` Stefan Monnier [this message]
2011-02-25 14:38 ` Leo
2011-03-01 3:25 ` Glenn Morris
2011-03-01 4:31 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4o7t1o9z.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=3230@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).