From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: rogers-emacs@rgrjr.dyndns.org, 6870@debbugs.gnu.org
Subject: bug#6870: Make vc-root-diff work in more modes
Date: Mon, 04 Jul 2011 14:13:42 -0400 [thread overview]
Message-ID: <jwv4o319ar3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m3liwem5v7.fsf@quimbies.gnus.org> (Lars Magne Ingebrigtsen's message of "Mon, 04 Jul 2011 17:18:36 +0200")
>> (cond ((derived-mode-p 'vc-dir-mode) vc-dir-backend)
>> - ((derived-mode-p 'dired-mode) (vc-responsible-backend default-directory))
>> - (vc-mode (vc-backend buffer-file-name))))
>> + (vc-mode (vc-backend buffer-file-name))
>> + (t (vc-responsible-backend default-directory))))
>> rootdir working-revision)
>> (unless backend
>> (error "Buffer is not version controlled"))
> This looks very reasonable to me, but I'm not all that familiar with
> vc.el internals. Does anybody else have any opinions on this?
It's only reasonable in buffers where default-directory is really
meaningful. E.g. in *Help* or *info* it's likely not going to do you
much good.
So feel free to add more major modes (rather than just `dired'), but
I don't think using (vc-responsible-backend default-directory)
everywhere is a good idea.
Stefan
next prev parent reply other threads:[~2011-07-04 18:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 1:55 bug#6870: Make vc-root-diff work in more modes rogers-emacs
2011-07-04 15:18 ` Lars Magne Ingebrigtsen
2011-07-04 18:13 ` Stefan Monnier [this message]
2011-07-05 13:32 ` Lars Magne Ingebrigtsen
2011-07-05 19:04 ` Stefan Monnier
2011-07-05 20:58 ` Chong Yidong
2020-08-25 13:38 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv4o319ar3.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=6870@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=rogers-emacs@rgrjr.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).